Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/wrong-value-of-parsing-dates #4

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Conversation

rjsamra
Copy link
Member

@rjsamra rjsamra commented Jun 12, 2024

fix for converting of dates

@rjsamra rjsamra self-assigned this Jun 12, 2024
@rjsamra rjsamra linked an issue Jun 12, 2024 that may be closed by this pull request
Copy link

@carlmagumpara carlmagumpara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi what if the column name is not exactly date or Date? example: Date of Birth etc.. i think you need to add condition if the value is valid date then parse it.

@rjsamra
Copy link
Member Author

rjsamra commented Jun 13, 2024

Yes, fair point

Let me have a look into it and make a fix accordingly

@rjsamra rjsamra requested a review from carlmagumpara June 15, 2024 18:11
@rjsamra rjsamra merged commit ebd4ee8 into main Jun 16, 2024
@rjsamra rjsamra deleted the fix/3-wrong-value-of-parsing-dates branch June 16, 2024 06:23
@rjsamra rjsamra linked an issue Aug 7, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong value of parsing dates Feature Request: Support for CSV File Conversion
2 participants