Skip to content

Commit

Permalink
Add flutter config to macOS targets (flutter#7756)
Browse files Browse the repository at this point in the history
In 9345274 (flutter#7642), //shell/platform/darwin:framework_shared was added
without the root flutter config, causing a build breakage in Fuchsia,
where flutter sits under //third_party/flutter as opposed to at the
root. The flutter root config is required to set -I../../third_party as
an include path.
  • Loading branch information
cbracken authored and zanderso committed Feb 8, 2019
1 parent 4d3a112 commit 3bfd265
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions shell/platform/darwin/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ source_set("framework_shared") {
set_sources_assignment_filter(sources_assignment_filter)

defines = [ "FLUTTER_FRAMEWORK" ]

public_configs = [ "$flutter_root:config" ]
}

executable("flutter_channels_unittests") {
Expand All @@ -78,4 +80,6 @@ executable("flutter_channels_unittests") {
"$flutter_root/testing",
"//third_party/dart/runtime:libdart_jit",
]

public_configs = [ "$flutter_root:config" ]
}

0 comments on commit 3bfd265

Please sign in to comment.