Skip to content

Commit

Permalink
Add --no-full-dart-sdk option to GN (flutter#8196)
Browse files Browse the repository at this point in the history
Allows enabling/disabling building trained snapshots for dart2js and
dartdevc.
  • Loading branch information
cbracken authored Mar 17, 2019
1 parent 5b09204 commit d9fda1c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tools/gn
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,8 @@ def to_gn_args(args):
if args.arm_float_abi:
gn_args['arm_float_abi'] = args.arm_float_abi

# Whether to build all dart snapshots.
if args.full_dart_sdk:
gn_args['dart_platform_sdk'] = False
# Whether to build trained Dart SDK snapshots of dart2js and dartdevc.
gn_args['dart_platform_sdk'] = not args.full_dart_sdk

return gn_args

Expand Down Expand Up @@ -289,8 +288,9 @@ def parse_args(args):

parser.add_argument('--out-dir', default='', type=str)

parser.add_argument('--full-dart-sdk', default=True, action='store_true',
help='include trained dart2js and dartdevc snapshots. Enable only on steps that create an sdk')
parser.add_argument('--full-dart-sdk', default=False, action='store_true',
help='include trained dart2js and dartdevc snapshots. Enable only on steps that create an SDK')
parser.add_argument('--no-full-dart-sdk', dest='full_dart_sdk', action='store_false')

return parser.parse_args(args)

Expand Down

0 comments on commit d9fda1c

Please sign in to comment.