-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregator
dependency injection, min
/max
, and skipNaN
#1108
Draft
Jolanrensen
wants to merge
15
commits into
master
Choose a base branch
from
min-max
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egation of specific abilities of the aggregator to whichever combination the client chooses. And instead of having to create a new class for each combination, the same function can be used.
…ingAggregationHandler for min/max etc. Added SequenceBestBy.kt helpers
Aggregator dependency injection
, min/max, and skipNaN
Aggregator dependency injection
, min/max, and skipNaN
Aggregator
dependency injection, min
/max
, and skipNaN
Seems our notebook tests now fail because of https://youtrack.jetbrains.com/issue/KTNB-967/IllegalStateException-null-DefinitelyNotNullType-for-T-exception-while-analyzing-expression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #961
AggregatorInputHandler
, has 2 implementationsAggregatorAggregationHandler
, has 2 implementationsAggregatorMultipleColumnsHandler
, has 3 implementationsTogether they can instantiate
Aggregator
in any combination you like :)Added
Aggregator.aggregateByOrNull()
functions for selecting aggregators, like min/max, but also median/percentile in the future, with the Sequence.bestBy family of internal functionsadded skipNaN option to sum, mean,
min, maxRewrote min/max with correct types (
T : Comparable<T & Any>?
)<T : Comparable<T & Any>?>
for normal comparables<T : Number?>
for mixed number types<T> ... where T : Number?, T : Comparable<T & Any?>
for normal numbersmin
with numbers would then act like aminBy { it.toUnifiedNumber() }
as it needs to return unconverted minimal valueTODO remove skipNaN from min, max again; min nor max can ever return NaN, because any number compared to NaN is considered "better"
TODO More tests?