KRPC-167 Internal symbols are poorly exposed #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts where kxrpc is configured
Mr3zee
force-pushed
the
internal-api-namings
branch
from
4a27cb0 to
e6dc855
Compare
e5l
reviewed
Mar 19, 2025
|
@e5l You mean JvmSynthetic ? |
|
yep, I checked and it will not work. It would be nice to hide it somehow |
|
@e5l I'll make a ticket for Kotlin team, we'll see what they can say Meanwhile, we can proceed with this PR as a quick fix |
|
thanks, sure |
e5l
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
All
Problem Description
Some internal APIs have unfortunate namings, that can pop up in IDE auto completion
Solution
Rename the most annoying internal APIs