Use importlib.metadata (pygal requires 3.8+) #546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gentooboontoo :) |
|
Thanks @akx. Unfortunately Unless I am wrong, using |
|
@gentooboontoo Shouldn't tests catch that? I'm currently on mobile so I can't see whether CI has run here. |
|
(Back from lunch.) Oh, there is no CI that would run here... I |
This was referenced Nov 21, 2023
akx
force-pushed
the
importlib-metadata
branch
from
fefae86 to
34b2fa1
Compare
akx
force-pushed
the
importlib-metadata
branch
from
34b2fa1 to
6cef48e
Compare
|
Okay, never mind – until targeting Python 3.10+, using See https://pypi.org/project/backports.entry-points-selectable/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #545 (comment)
importlib_metadatafrom PyPI is only required for Python < 3.8;importlib.metadatais always available on 3.8+, and the minimumpython_requireshere is 3.8+ (01649cb).Regressed in d1d02c6