refactored res.redirect() with respondTo()

Kranthi0312 · Feb 23, 2012 · a47660b · a47660b
1 parent e229118
commit a47660b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/lib/response.js b/lib/response.js
@@ -541,13 +541,15 @@ res.redirect = function(url){
   }
 
   // Support text/{plain,html} by default
-  if (req.accepts('html')) {
-    body = '<p>' + statusCodes[status] + '. Redirecting to <a href="' + url + '">' + url + '</a></p>';
-    this.set('Content-Type', 'text/html');
-  } else {
-    body = statusCodes[status] + '. Redirecting to ' + url;
-    this.set('Content-Type', 'text/plain');
-  }
+  this.respondTo({
+    'text/plain': function(){
+      body = statusCodes[status] + '. Redirecting to ' + url;
+    },
+
+    'text/html': function(){
+      body = '<p>' + statusCodes[status] + '. Redirecting to <a href="' + url + '">' + url + '</a></p>';
+    }
+  })
 
   // Respond
   this.statusCode = status;

diff --git a/test/res.redirect.js b/test/res.redirect.js
@@ -245,7 +245,7 @@ describe('res', function(){
 
       request(app)
       .get('/')
-      .set('Accept', 'text/plain')
+      .set('Accept', 'text/plain, */*')
       .end(function(res){
         res.headers.should.have.property('location', 'http://google.com');
         res.body.should.equal('Moved Temporarily. Redirecting to http://google.com');