Merged PR 32885: fix disp-perf-test-app error on chrome when sending …

…an undefined parameter fix disp-perf-test-app error on chrome when sending an undefined parameter
KrishKash · Jun 24, 2019 · 1c8c31d · 1c8c31d
1 parent 86465f0
commit 1c8c31d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/test-apps/display-performance-test-app/src/common/DisplayPerfRpcInterface.ts b/test-apps/display-performance-test-app/src/common/DisplayPerfRpcInterface.ts
@@ -31,7 +31,7 @@ export default class DisplayPerfRpcInterface extends RpcInterface {
   public async saveCsv(_outputPath: string, _outputName: string, _rowDataJson: string, _csvFormat?: string): Promise<void> { return this.forward(arguments); }
   public async savePng(_fileName: string, _png: string): Promise<void> { return this.forward(arguments); }
 
-  public async finishCsv(_output: string, _outputPath: string | undefined, _outputName: string | undefined, _csvFormat?: string | undefined): Promise<void> { return this.forward(arguments); }
+  public async finishCsv(_output: string, _outputPath?: string, _outputName?: string, _csvFormat?: string): Promise<void> { return this.forward(arguments); }
   public async finishTest(): Promise<void> { return this.forward(arguments); }
 
   public async readExternalSavedViews(_filename: string): Promise<string> { return this.forward(arguments); }

diff --git a/test-apps/display-performance-test-app/src/frontend/DisplayPerformanceTestApp.ts b/test-apps/display-performance-test-app/src/frontend/DisplayPerformanceTestApp.ts
@@ -1172,6 +1172,7 @@ async function main() {
   if (renderComp.unmaskedVendor) renderData += "Unmasked Vendor: " + renderComp.unmaskedVendor + "\r\n";
   if (renderComp.missingRequiredFeatures) renderData += "Missing Required Features: " + renderComp.missingRequiredFeatures + "\r\n";
   if (renderComp.missingOptionalFeatures) renderData += "Missing Optional Features: " + renderComp.missingOptionalFeatures + "\"\r\n";
+  if (jsonData.csvFormat === undefined) jsonData.csvFormat = "original";
   await DisplayPerfRpcInterface.getClient().finishCsv(renderData, jsonData.outputPath, jsonData.outputName, jsonData.csvFormat);
 
   DisplayPerfRpcInterface.getClient().finishTest(); // tslint:disable-line:no-floating-promises