Merged PR 90403: fix: gpu profiler fix for readPixel calls

KrishKash · Jun 1, 2020 · 3d364cc · 3d364cc
1 parent a43290a
commit 3d364cc
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/common/changes/@bentley/imodeljs-frontend/fix-gpuProfiler_2020-06-01-18-53.json b/common/changes/@bentley/imodeljs-frontend/fix-gpuProfiler_2020-06-01-18-53.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@bentley/imodeljs-frontend",
+      "comment": "Gpu profiler fix for readPixel calls",
+      "type": "none"
+    }
+  ],
+  "packageName": "@bentley/imodeljs-frontend",
+  "email": "[email protected]"
+}
diff --git a/core/frontend/src/render/webgl/SceneCompositor.ts b/core/frontend/src/render/webgl/SceneCompositor.ts
@@ -857,11 +857,11 @@ abstract class Compositor extends SceneCompositor {
 
       this.target.beginPerfMetricRecord("Render Translucent Layers", true);
       this.renderLayers(commands, false, RenderPass.TranslucentLayers);
-      this.target.endPerfMetricRecord();
+      this.target.endPerfMetricRecord(true);
 
       this.target.beginPerfMetricRecord("Render Overlay Layers", true);
       this.renderLayers(commands, false, RenderPass.OverlayLayers);
-      this.target.endPerfMetricRecord();
+      this.target.endPerfMetricRecord(true);
 
       this.target.popViewClip();
     }
@@ -870,10 +870,10 @@ abstract class Compositor extends SceneCompositor {
       return;
 
     // Now populate the opaque passes with any pickable world overlays
-    this.target.beginPerfMetricRecord("Overlay Draws");
+    this.target.beginPerfMetricRecord("Overlay Draws", true);
     commands.initForPickOverlays(sceneOverlays, overlayDecorations);
     if (commands.isEmpty) {
-      this.target.endPerfMetricRecord(); // End Overlay Draws record if returning
+      this.target.endPerfMetricRecord(true); // End Overlay Draws record if returning
       return;
     }