forked from FuelLabs/sway
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
…uelLabs#4168) ## Description In anticipation of the upcoming ipfs support (FuelLabs#3926), this PR refactors `forc-pkg` to more clearly separate out the "source" abstraction from the rest of the pkg-handling logic. We do so by creating a common interface for sources in the form of traits for pinning and fetching. This should allow for adding in the upcoming ipfs implementation (or future alternative source kind) in a manner that doesn't further complicate the rest of package handling. There is still room for further refactor of `pkg.rs`, but this should do enough to clear the way for ipfs support and closes FuelLabs#3927. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. Co-authored-by: Joshua Batty <[email protected]>
- Loading branch information
1 parent
a1cacd6
commit 9346bf4
Showing
9 changed files
with
1,305 additions
and
1,135 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ | |
pub mod lock; | ||
pub mod manifest; | ||
mod pkg; | ||
pub mod source; | ||
|
||
pub use lock::Lock; | ||
pub use manifest::{ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.