Skip to content

Commit

Permalink
Update CONTRIBUTING.md (mozilla#2302)
Browse files Browse the repository at this point in the history
  • Loading branch information
johngruen authored and Cory Price committed Mar 13, 2017
1 parent 6433a02 commit 40f095d
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ some changes or improvements or alternatives.

We try to avoid landing any code without at least a cursory review.

General rules for picking up reviews:
- if you are going to review a PR, assign yourself to it
- assigned person is responsible for helping get the PR over the finish line
- if a PR doesn't have an assigned person, it's up for grabs

Reviewers will run through roughly the following checklist:
- Does the code do what it says it does?
- Is the proposed fix the right fix? Does it address the underlying cause of the bug?
Expand Down

0 comments on commit 40f095d

Please sign in to comment.