Skip to content

Commit

Permalink
Remove obsolete comment about labels-crossing-subpackage check happen…
Browse files Browse the repository at this point in the history
…ing in legacy package loading. It now happens in skyframe package loading.

--
MOS_MIGRATED_REVID=87972524
  • Loading branch information
haxorz authored and damienmg committed Mar 10, 2015
1 parent df22aaf commit 9901cfb
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,6 @@ private static boolean markDependenciesAndPropagateInconsistentFilesystemExcepti
}
packageShouldBeInError = markFileDepsAndPropagateInconsistentFilesystemExceptions(
pkg.getName(), subincludeFileDepKeys, env, pkg.containsErrors());
// Another concern is a subpackage cutting off the subinclude label, but this is already
// handled by the legacy package loading code which calls into our SkyframePackageLocator.

// TODO(bazel-team): In the long term, we want to actually resolve the glob patterns within
// Skyframe. For now, just logging the glob requests provides correct incrementality and
Expand Down

0 comments on commit 9901cfb

Please sign in to comment.