Skip to content

Commit

Permalink
scsi-generic: add missing reset handler
Browse files Browse the repository at this point in the history
Ensure that pending requests of a SCSI generic device are purged on
system reset. This also avoids calling a NULL function in lsi53c895a.
The lsi code was recently changed to call the .qdev.reset function.

Signed-off-by: Bernhard Kohl <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
  • Loading branch information
Bernhard Kohl authored and kevmw committed Sep 21, 2010
1 parent 6f5f060 commit f8b6d67
Showing 1 changed file with 19 additions and 2 deletions.
21 changes: 19 additions & 2 deletions hw/scsi-generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -455,15 +455,31 @@ static int get_stream_blocksize(BlockDriverState *bdrv)
return (buf[9] << 16) | (buf[10] << 8) | buf[11];
}

static void scsi_destroy(SCSIDevice *d)
static void scsi_generic_purge_requests(SCSIGenericState *s)
{
SCSIGenericState *s = DO_UPCAST(SCSIGenericState, qdev, d);
SCSIGenericReq *r;

while (!QTAILQ_EMPTY(&s->qdev.requests)) {
r = DO_UPCAST(SCSIGenericReq, req, QTAILQ_FIRST(&s->qdev.requests));
if (r->req.aiocb) {
bdrv_aio_cancel(r->req.aiocb);
}
scsi_remove_request(r);
}
}

static void scsi_generic_reset(DeviceState *dev)
{
SCSIGenericState *s = DO_UPCAST(SCSIGenericState, qdev.qdev, dev);

scsi_generic_purge_requests(s);
}

static void scsi_destroy(SCSIDevice *d)
{
SCSIGenericState *s = DO_UPCAST(SCSIGenericState, qdev, d);

scsi_generic_purge_requests(s);
blockdev_mark_auto_del(s->qdev.conf.bs);
}

Expand Down Expand Up @@ -537,6 +553,7 @@ static SCSIDeviceInfo scsi_generic_info = {
.qdev.name = "scsi-generic",
.qdev.desc = "pass through generic scsi device (/dev/sg*)",
.qdev.size = sizeof(SCSIGenericState),
.qdev.reset = scsi_generic_reset,
.init = scsi_generic_initfn,
.destroy = scsi_destroy,
.send_command = scsi_send_command,
Expand Down

0 comments on commit f8b6d67

Please sign in to comment.