Skip to content

Commit

Permalink
pybamm-team#3252 Simon's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@brosaplanella
brosaplanella committed Aug 9, 2023
1 parent 5176f4e commit 5fc57df
Showing 1 changed file with 22 additions and 21 deletions.
43 changes: 22 additions & 21 deletions docs/source/examples/notebooks/models/loss_of_active_materials.ipynb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
{
"data": {
"application/vnd.jupyter.widget-view+json": {
"model_id": "089644e32d284c19ba8ac4c24c874f82",
"model_id": "3558ac2f7db145baadec9a28e236483e",
"version_major": 2,
"version_minor": 0
},
Expand All @@ -95,7 +95,7 @@
{
"data": {
"text/plain": [
"<pybamm.plotting.quick_plot.QuickPlot at 0x7ff4040dad00>"
"<pybamm.plotting.quick_plot.QuickPlot at 0x7f91cc5d2d00>"
]
},
"execution_count": 2,
Expand Down Expand Up @@ -131,7 +131,7 @@
{
"data": {
"application/vnd.jupyter.widget-view+json": {
"model_id": "47fbae0fea31417bb4e0c142bb86a891",
"model_id": "9ff0e45a0c8c47b2b8d21da91b6110c1",
"version_major": 2,
"version_minor": 0
},
Expand All @@ -145,7 +145,7 @@
{
"data": {
"text/plain": [
"<pybamm.plotting.quick_plot.QuickPlot at 0x7ff3a9b80b20>"
"<pybamm.plotting.quick_plot.QuickPlot at 0x7f9179084910>"
]
},
"execution_count": 3,
Expand Down Expand Up @@ -197,13 +197,13 @@
},
{
"cell_type": "code",
"execution_count": 8,
"execution_count": 4,
"metadata": {},
"outputs": [
{
"data": {
"application/vnd.jupyter.widget-view+json": {
"model_id": "722a6c517e69471e81d028b603a1730d",
"model_id": "53f5eacbb94b4ae29acee57db4bf7785",
"version_major": 2,
"version_minor": 0
},
Expand All @@ -217,10 +217,10 @@
{
"data": {
"text/plain": [
"<pybamm.plotting.quick_plot.QuickPlot at 0x7ff39fab1fa0>"
"<pybamm.plotting.quick_plot.QuickPlot at 0x7f91cc77d9a0>"
]
},
"execution_count": 8,
"execution_count": 4,
"metadata": {},
"output_type": "execute_result"
}
Expand Down Expand Up @@ -280,18 +280,18 @@
},
{
"cell_type": "code",
"execution_count": 12,
"execution_count": 5,
"metadata": {},
"outputs": [
{
"data": {
"application/vnd.jupyter.widget-view+json": {
"model_id": "166fc48f5bcd4a1c83a10db59bbab2e5",
"model_id": "15acf6373f874463ba95de522d12fc89",
"version_major": 2,
"version_minor": 0
},
"text/plain": [
"interactive(children=(FloatSlider(value=0.0, description='t', max=3.502238741966222, step=0.03502238741966222)…"
"interactive(children=(FloatSlider(value=0.0, description='t', max=3.4962610293431426, step=0.03496261029343142…"
]
},
"metadata": {},
Expand All @@ -300,17 +300,17 @@
{
"data": {
"text/plain": [
"<pybamm.plotting.quick_plot.QuickPlot at 0x7ff3a17c81c0>"
"<pybamm.plotting.quick_plot.QuickPlot at 0x7f9170283dc0>"
]
},
"execution_count": 12,
"execution_count": 5,
"metadata": {},
"output_type": "execute_result"
}
],
"source": [
"def current_LAM(i, T):\n",
" return -1e-8 * abs(i)\n",
" return -1e-10 * (abs(i) + 1e3 * abs(i) ** 0.5)\n",
"\n",
"model = pybamm.lithium_ion.DFN(\n",
" options=\n",
Expand Down Expand Up @@ -360,7 +360,7 @@
},
{
"cell_type": "code",
"execution_count": null,
"execution_count": 6,
"metadata": {},
"outputs": [
{
Expand All @@ -369,12 +369,13 @@
"text": [
"[1] Weilong Ai, Ludwig Kraft, Johannes Sturm, Andreas Jossen, and Billy Wu. Electrochemical thermal-mechanical modelling of stress inhomogeneity in lithium-ion pouch cells. Journal of The Electrochemical Society, 167(1):013512, 2019. doi:10.1149/2.0122001JES.\n",
"[2] Joel A. E. Andersson, Joris Gillis, Greg Horn, James B. Rawlings, and Moritz Diehl. CasADi – A software framework for nonlinear optimization and optimal control. Mathematical Programming Computation, 11(1):1–36, 2019. doi:10.1007/s12532-018-0139-4.\n",
"[3] Rutooj Deshpande, Mark Verbrugge, Yang-Tse Cheng, John Wang, and Ping Liu. Battery cycle life prediction with coupled chemical degradation and fatigue mechanics. Journal of the Electrochemical Society, 159(10):A1730, 2012. doi:10.1149/2.049210jes.\n",
"[4] Marc Doyle, Thomas F. Fuller, and John Newman. Modeling of galvanostatic charge and discharge of the lithium/polymer/insertion cell. Journal of the Electrochemical society, 140(6):1526–1533, 1993. doi:10.1149/1.2221597.\n",
"[5] Charles R. Harris, K. Jarrod Millman, Stéfan J. van der Walt, Ralf Gommers, Pauli Virtanen, David Cournapeau, Eric Wieser, Julian Taylor, Sebastian Berg, Nathaniel J. Smith, and others. Array programming with NumPy. Nature, 585(7825):357–362, 2020. doi:10.1038/s41586-020-2649-2.\n",
"[6] Scott G. Marquis. Long-term degradation of lithium-ion batteries. PhD thesis, University of Oxford, 2020.\n",
"[7] Jorn M. Reniers, Grietus Mulder, and David A. Howey. Review and performance comparison of mechanical-chemical degradation models for lithium-ion batteries. Journal of The Electrochemical Society, 166(14):A3189, 2019. doi:10.1149/2.0281914jes.\n",
"[8] Valentin Sulzer, Scott G. Marquis, Robert Timms, Martin Robinson, and S. Jon Chapman. Python Battery Mathematical Modelling (PyBaMM). Journal of Open Research Software, 9(1):14, 2021. doi:10.5334/jors.309.\n",
"[3] Chang-Hui Chen, Ferran Brosa Planella, Kieran O'Regan, Dominika Gastol, W. Dhammika Widanage, and Emma Kendrick. Development of Experimental Techniques for Parameterization of Multi-scale Lithium-ion Battery Models. Journal of The Electrochemical Society, 167(8):080534, 2020. doi:10.1149/1945-7111/ab9050.\n",
"[4] Rutooj Deshpande, Mark Verbrugge, Yang-Tse Cheng, John Wang, and Ping Liu. Battery cycle life prediction with coupled chemical degradation and fatigue mechanics. Journal of the Electrochemical Society, 159(10):A1730, 2012. doi:10.1149/2.049210jes.\n",
"[5] Marc Doyle, Thomas F. Fuller, and John Newman. Modeling of galvanostatic charge and discharge of the lithium/polymer/insertion cell. Journal of the Electrochemical society, 140(6):1526–1533, 1993. doi:10.1149/1.2221597.\n",
"[6] Charles R. Harris, K. Jarrod Millman, Stéfan J. van der Walt, Ralf Gommers, Pauli Virtanen, David Cournapeau, Eric Wieser, Julian Taylor, Sebastian Berg, Nathaniel J. Smith, and others. Array programming with NumPy. Nature, 585(7825):357–362, 2020. doi:10.1038/s41586-020-2649-2.\n",
"[7] Scott G. Marquis. Long-term degradation of lithium-ion batteries. PhD thesis, University of Oxford, 2020.\n",
"[8] Jorn M. Reniers, Grietus Mulder, and David A. Howey. Review and performance comparison of mechanical-chemical degradation models for lithium-ion batteries. Journal of The Electrochemical Society, 166(14):A3189, 2019. doi:10.1149/2.0281914jes.\n",
"[9] Valentin Sulzer, Scott G. Marquis, Robert Timms, Martin Robinson, and S. Jon Chapman. Python Battery Mathematical Modelling (PyBaMM). Journal of Open Research Software, 9(1):14, 2021. doi:10.5334/jors.309.\n",
"\n"
]
}
Expand Down

0 comments on commit 5fc57df

Please sign in to comment.