Skip to content

Commit

Permalink
Refactor default abs sender (rubenlagus#272)
Browse files Browse the repository at this point in the history
* refactor-default-abs-sender: move all returns to `try` scope

- it makes clear that return would not happen if some exception has been thrown

* refactor-default-abs-sender: extract `sendHttpPostRequest` method

* refactor-default-abs-sender: inline usage of `sendHttpPostRequest` in most occurrences

* refactor-default-abs-sender: extract creation of `HttpPost` with configuration to method

* refactor-default-abs-sender: rearrange code to ease up refactoring

* refactor-default-abs-sender: extract `sendMethodRequest` method

* refactor-default-abs-sender: move temporary file names to variables

* refactor-default-abs-sender: extract files downloading to separate methods

* refactor-default-abs-sender: extract creation of `Runnable` for async file download to method

* refactor-default-abs-sender: extract `assertParamNotNull` method

* refactor-default-abs-sender: rename `tryToDownloadToTemporaryFile` method
  • Loading branch information
rgolyshev authored and rubenlagus committed Jul 20, 2017
1 parent 8b977fa commit cbcfab5
Showing 1 changed file with 105 additions and 201 deletions.
Loading

0 comments on commit cbcfab5

Please sign in to comment.