lsf support #48
lsf support #48
Conversation
|
In principle looks good. A few things A) Could you rebase off master. I totally screwed up with the last release. The submission convert names need to be changed (e.g. from msubtorque to msubtorquepdsh). I've made the fix in master, but I need you to adjust accordingly. Totally my bad, sorry. There will be adjustments in the script-templates directory as a result (lsf -> lsf-mpirun everywhere). B) Could you add the appropriate information to the README file. Basically everywhere it talks about how to submit a job via msub, add the lsf equivalent. Every where it talks about "you'll find msub + slurm scripts in submission-scripts/....", add the appropriate lsf stuff. There might be a few more places too, like the general header in README & README.md that says LSF is supported. |
|
Oh, and update the .travis.yml file for the lsf build |
|
This should be good and was testing with the testall |
| @@ -79,3 +79,26 @@ then | |||
| export MAGPIE_TIMELIMIT_MINUTES=$(expr ${PBS_WALLTIME} / 60) | |||
| fi | |||
| fi | |||
|
|
|||
| if [ "${MAGPIE_SUBMISSION_TYPE}" == "lsf" ] || [ "${MAGPIE_SUBMISSION_TYPE}" == "lsfmpirun" ] | |||
There was a problem hiding this comment.
no need to check for "lsf" here, since there's no need for backwards compatibility. We only support "lsfmpirun"
|
Really close. Only 1 minor nit. Also, could you copy over the minor change in the README to README.md. |
|
Oh, and on the first part of the "Basic Idea" text in README & README.md, could you mention LSF. Thanks |
bpanneton
force-pushed
the
lsf-support
branch
2 times, most recently
from
423f22c to
2fdc553
Compare
|
LGTM |
Support for lsf