Add record count down #3467

liushuyu · 2017-03-30T19:53:50Z

Do not merge this until it is told to do so

Tagging my "mentor" @jasp00

In respond to #3394

This change is

include/MainWindow.h

Umcaruje · 2017-03-30T19:59:48Z

src/gui/MainWindow.cpp

@@ -552,13 +555,20 @@ void MainWindow::finalize()
 								m_toolBar );
 	controllers_window->setShortcut( Qt::Key_F11 );

+    m_countDownClock = new LcdSpinBox(2, this, tr("Count Down Clock"));
+
+    m_countDownClock->setLabel( tr("SEC") );


The countdown should really be in bars/beats, not seconds. When you record you always want to be relative to the beat, because the countdown actually gives musicians time to align themselves with the beat. An arbitrary second value can't do that.

Well, in this case, we may want to implement a conversion algorithm and makes it public in Engine or somewhere, this problem was also a headache in my previous PR (Go to feature), it will introduce offsets when doing the conversions.

And maybe here we can toggle on the metronome automatically to assist the recording preparation even better?

Yes, absolutely. The metronome ought to be more intuitive, that's a step in the right direction.

Because I think we are going to use QTimer to do the delay process, and QTimer only accepts milliseconds, so we need to first convert ticks into milliseconds.
I came up with such conversion method:

The equation (1) is our original algorithm found in TimeDisplayWidget.cpp:112
The equation (2) is to solve the equation (1) given Tick value to express Msec as a function of Tick tempo and TicksPerTack
The equation (4) is to ease manual verification of whether the equation (2) works correctly.
As far as I could tell, given the precise value of ticks (preserving at least 1 decimal point) can give the very close output (around +- 3 msec at 999 BPM)

In the final version don't use 1250 like a magic number, cause the TicksPerTact can change in the future. It's better to have a constant that's 24000/TicksPerTact

src/gui/MainWindow.cpp

Umcaruje · 2017-03-31T15:37:51Z

src/gui/MainWindow.cpp



 void MainWindow::toggleControllerRack()
 {
-	toggleWindow( gui->getControllerRackView() );
+    toggleWindow( gui->getControllerRackView() );


missed one spot with spaces here

Umcaruje · 2017-03-31T15:38:14Z

src/gui/MainWindow.cpp

 	m_toolBarLayout->addWidget( song_editor_window, 1, 1 );
 	m_toolBarLayout->addWidget( bb_editor_window, 1, 2 );
 	m_toolBarLayout->addWidget( piano_roll_window, 1, 3 );
 	m_toolBarLayout->addWidget( automation_editor_window, 1, 4 );
 	m_toolBarLayout->addWidget( fx_mixer_window, 1, 5 );
 	m_toolBarLayout->addWidget( project_notes_window, 1, 6 );
 	m_toolBarLayout->addWidget( controllers_window, 1, 7 );
+    m_toolBarLayout->addWidget( m_countDownClock, 1, 8 );


jasp00

Countdown should be based on the rendering process, without timers.

jasp00 · 2017-04-01T01:39:34Z

src/gui/MainWindow.cpp

+	connect( &m_recordCountDownTimer, SIGNAL( timeout()), this, SLOT(decrementRecordCountDown()) );
+	connect( Engine::getSong(), SIGNAL( recordCoundDown()), this, SLOT(startRecordCountDown()) );
+	m_countDownValue = new LcdSpinBoxModel();
+	m_countDownValue->setRange( 0, 99 );


Please add

// TODO: Support -1 for automatic

jasp00 · 2017-04-01T01:45:48Z

include/MainWindow.h

@@ -232,6 +235,10 @@ public slots:

 	ToolButton * m_metronomeToggle;

+	LcdSpinBox * m_countDownClock;
+
+	LcdSpinBoxModel * m_countDownValue;


You would probably like to have this model in Song because the feature should work with any interface.

jasp00 · 2017-04-01T01:53:42Z

src/gui/MainWindow.cpp

+
+	m_countDownClock->setLabel( tr("SEC") );
+	m_countDownClock->setModel( m_countDownValue );
+	connect( m_countDownValue, SIGNAL(dataChanged()), this, SLOT( updateCountDownDuration() ) );


You should only connect the manualChange signal.

Ahh, there's a small problem, I don't know why the manualChange wasn't fired during my testing.

manualChange works. What object were you connecting?

manualChange works. What object were you connecting?

I was connectingm_countDownClock, and I found the slot is never got called.

src/gui/MainWindow.cpp

jasp00 · 2017-04-01T02:11:58Z

include/MainWindow.h

@@ -224,6 +226,7 @@ public slots:

 	QBasicTimer m_updateTimer;
 	QTimer m_autoSaveTimer;
+	QTimer m_recordCountDownTimer;


These timer facilities are not needed in the GUI, the model should handle the countdown.

jasp00 · 2017-04-01T02:12:56Z

include/MainWindow.h

@@ -243,6 +250,8 @@ private slots:
 	void updateViewMenu( void );
 	void updateConfig( QAction * _who );
 	void onToggleMetronome();
+	void startRecordCountDown();
+	void decrementRecordCountDown();


These are not needed.

jasp00 · 2017-04-01T02:15:55Z

include/Song.h

@@ -254,6 +254,10 @@ class EXPORT Song : public TrackContainer
 		return m_timeSigModel;
 	}

+	void setRecordDelay( int time );
+	int getRecordDelay();
+	void startRecordCountDown();


startRecordCountDown would be private because the countdown should be integrated with record.

jasp00 · 2017-04-01T02:24:06Z

src/gui/editors/PianoRoll.cpp

@@ -4357,15 +4357,17 @@ void PianoRollWindow::stop()

 void PianoRollWindow::record()
 {
-	m_editor->record();
+	Engine::getSong()->startRecordCountDown();
+	QTimer::singleShot( Engine::getSong()->getRecordDelay() * 1000 , m_editor, SLOT( record() ) );


Since the countdown will be based on bars and the metronome is going to play, you should rely on the rendering process and tick count instead of timers.

This is because I haven't familiar with the rendering process of LMMS, I will try to understand it before doing this.

liushuyu · 2017-04-01T02:44:01Z

@jasp00 Thanks for your feedback! I will fix the code accordingly.

liushuyu · 2017-04-08T00:21:57Z

Well, I am writing to let you guys know I am still alive and I just have been fully occupied, hopefully I will have some time this weekend.
And I don't know how to make metronome tick while hold the record process, but I'll try to figure this out myself first before asking for help.

liushuyu · 2017-04-20T09:03:55Z

Okay, I feel like to ditch all the work here, because I think I need a clear mind to implement a better approach.
So I think the implementation should go as follows:

~~Add count down clock~~ This can be preserved, but the model should be in Song class
In Mixer class, add an exception to metronome trigger condition to make it tick when counting down, and together a count down process here. (IIRC, should be in Mixer::renderNextBuffer() ?)
To prevent note input during count down, we need to modify eachrecord() implementation to block input when in counting down status?

mirk0dex · 2024-02-28T14:35:05Z

Any updates?

Rossmaxx · 2024-06-14T12:41:12Z

Any updates?

Looks like this PR is dead

liushuyu requested a review from jasp00 March 30, 2017 19:53

Umcaruje reviewed Mar 30, 2017

View reviewed changes

include/MainWindow.h Outdated Show resolved Hide resolved

Umcaruje reviewed Mar 30, 2017

View reviewed changes

liushuyu force-pushed the countdown branch from 1556922 to b816c87 Compare March 30, 2017 20:23

Add record count down

1397141

liushuyu force-pushed the countdown branch from b816c87 to 1397141 Compare March 30, 2017 20:24

zapashcanon reviewed Mar 31, 2017

View reviewed changes

src/gui/MainWindow.cpp Show resolved Hide resolved

Umcaruje reviewed Mar 31, 2017

View reviewed changes

jasp00 reviewed Apr 1, 2017

View reviewed changes

Umcaruje changed the title ~~[WIP] Add record count down~~ Add record count down May 14, 2017

Umcaruje added the in progress label May 14, 2017

Umcaruje added this to the 1.3.0 milestone May 14, 2017

tresf mentioned this pull request Feb 25, 2018

Metronome pre-roll #4190

Closed

ryuukumar mentioned this pull request Jul 21, 2020

Reorganising LMMS, renaming editors and classes and everything in between (cont. #120) #5592

Closed

56 tasks

Rossmaxx modified the milestones: 1.3, 1.3+ Jun 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add record count down #3467

Add record count down #3467

liushuyu commented Mar 30, 2017 •

edited

Loading

Umcaruje Mar 30, 2017

liushuyu Mar 30, 2017

liushuyu Mar 30, 2017

Umcaruje Mar 30, 2017

liushuyu Mar 30, 2017 •

edited

Loading

Umcaruje Mar 31, 2017

Umcaruje Mar 31, 2017

Umcaruje Mar 31, 2017

jasp00 left a comment

jasp00 Apr 1, 2017

jasp00 Apr 1, 2017

jasp00 Apr 1, 2017

liushuyu Apr 1, 2017

jasp00 Apr 1, 2017

liushuyu Apr 20, 2017

jasp00 Apr 1, 2017

jasp00 Apr 1, 2017

jasp00 Apr 1, 2017

jasp00 Apr 1, 2017

liushuyu Apr 1, 2017

liushuyu commented Apr 1, 2017

liushuyu commented Apr 8, 2017

liushuyu commented Apr 20, 2017

mirk0dex commented Feb 28, 2024

Rossmaxx commented Jun 14, 2024

Add record count down #3467

Are you sure you want to change the base?

Add record count down #3467

Conversation

liushuyu commented Mar 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liushuyu Mar 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasp00 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liushuyu commented Apr 1, 2017

liushuyu commented Apr 8, 2017

liushuyu commented Apr 20, 2017

mirk0dex commented Feb 28, 2024

Rossmaxx commented Jun 14, 2024

liushuyu commented Mar 30, 2017 •

edited

Loading

liushuyu Mar 30, 2017 •

edited

Loading