-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sampletrack playes in any position in BB, too #4441
base: master
Are you sure you want to change the base?
Conversation
This should now working. I added a lots of comments to the code. |
I also found that when BB TCOs are overlapped, only the first one will be played with its length. |
@PhysSong thank you for reviewing this. I will look into it. 👍 |
New bug from 48af68: If BB TCO is n times longer than sample then it plays sample only once. |
@BaraMGB When do you think you'll finish this pull request? It's okay if you can't finish this soon, but I just want to know. |
It is on my list, yet. I'm busy at the moment with an other project. I think I can get back to this PR in a month. |
One bug still sneaked in. Sample doesn't stop playing when the BBTrack TCO ends. |
I was sure I fixed it. Can you provide steps to reproduce? @karmux |
Thank you @karmux , I fixed it. |
All previous issues has been fixed now. @BaraMGB thank you for working on this! One corner case issue that I found now and that can be reproduced using same project like on screenshot above:
|
|
||
/******************************************************************** | ||
* Now we iterate over all TCOs in the Sampletrack | ||
* If the sampletrack is within a BB-Container we have only one TCO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not true, the number of TCOs equals the number of BB tracks. nth TCO starts after n bars from the beginning(n starts from 0).
The assumption results in erratic behaviors when there are multiple BB tracks which contain sample TCOs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I look into it tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that when there are two or more BB Tracks and you press play inside one of these BB Tracks then samples from all BB tracks play at the same time. Also muted BB Tracks are playing (from BB Track and also from Song Editor).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple samples in BB Tracks is wonky already in stable-1.2 . It's not obvious how you are supposed to use them (not to me anyway). I think it would be good with a reference project based on the lmms samples for testing this.
@BaraMGB What's the status of this PR? Work in progress (you want to add/fix something more) or ready for review? Also, it would be nice if you could fix the "Conflicting files" (e.g. by rebasing or merging). |
Sorry, I don't think I can work on this very soon. |
Thanks for clarifying @BaraMGB . I'll take over the PR as author now. |
Thank you very much. |
@BaraMGB Let's re-target this to master. Is it OK for you if I change the PR base? (Or you can also do it yourself) Also, as this is not urgent anymore, I give the authorship of this PR back to you. |
OK, I just changed the base myself. It's now targeting master. |
fixes #4422
@karmux Please, can you test this? There's one problem I have to fix yet: The sample should stop playing when the BBTrack TCO ends.