Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampletrack playes in any position in BB, too #4441

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

BaraMGB
Copy link
Contributor

@BaraMGB BaraMGB commented Jun 20, 2018

fixes #4422

@karmux Please, can you test this? There's one problem I have to fix yet: The sample should stop playing when the BBTrack TCO ends.

@karmux
Copy link
Contributor

karmux commented Jun 20, 2018

@BaraMGB Thank you! Your changes fix both issues described in #4422.

The sample should stop playing when the BBTrack TCO ends.

Would be great!

@BaraMGB BaraMGB requested a review from PhysSong June 25, 2018 22:15
@BaraMGB
Copy link
Contributor Author

BaraMGB commented Jun 25, 2018

This should now working. I added a lots of comments to the code.

@PhysSong
Copy link
Member

I also found that when BB TCOs are overlapped, only the first one will be played with its length.

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Jun 27, 2018

@PhysSong thank you for reviewing this. I will look into it. 👍

@karmux
Copy link
Contributor

karmux commented Jun 27, 2018

New bug from 48af68: If BB TCO is n times longer than sample then it plays sample only once.

@PhysSong
Copy link
Member

@BaraMGB When do you think you'll finish this pull request? It's okay if you can't finish this soon, but I just want to know.

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Aug 17, 2018

It is on my list, yet. I'm busy at the moment with an other project. I think I can get back to this PR in a month.

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Oct 20, 2018

@karmux @PhysSong thank you for reviewing this.

@karmux
Copy link
Contributor

karmux commented Oct 20, 2018

One bug still sneaked in. Sample doesn't stop playing when the BBTrack TCO ends.

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Oct 20, 2018

I was sure I fixed it. Can you provide steps to reproduce? @karmux

@karmux
Copy link
Contributor

karmux commented Oct 20, 2018

I have around 5s sample there and it plays 2 times from beginning to the end.
screenshot_20181020_233145

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Oct 21, 2018

Thank you @karmux , I fixed it.

@karmux
Copy link
Contributor

karmux commented Oct 21, 2018

All previous issues has been fixed now. @BaraMGB thank you for working on this!

One corner case issue that I found now and that can be reproduced using same project like on screenshot above:

  • Mute BBTCO and start playing
  • Unmute right after first loop has started
  • Sample is playing which is expected
  • Mute again and unmute right after second loop has started
  • Sample is silent which is not expected


/********************************************************************
* Now we iterate over all TCOs in the Sampletrack
* If the sampletrack is within a BB-Container we have only one TCO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not true, the number of TCOs equals the number of BB tracks. nth TCO starts after n bars from the beginning(n starts from 0).
The assumption results in erratic behaviors when there are multiple BB tracks which contain sample TCOs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I look into it tomorrow.

Copy link
Contributor

@karmux karmux Oct 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that when there are two or more BB Tracks and you press play inside one of these BB Tracks then samples from all BB tracks play at the same time. Also muted BB Tracks are playing (from BB Track and also from Song Editor).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple samples in BB Tracks is wonky already in stable-1.2 . It's not obvious how you are supposed to use them (not to me anyway). I think it would be good with a reference project based on the lmms samples for testing this.

@JohannesLorenz
Copy link
Contributor

@BaraMGB What's the status of this PR? Work in progress (you want to add/fix something more) or ready for review?

Also, it would be nice if you could fix the "Conflicting files" (e.g. by rebasing or merging).

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Dec 25, 2019

Sorry, I don't think I can work on this very soon.

@JohannesLorenz
Copy link
Contributor

Thanks for clarifying @BaraMGB .

I'll take over the PR as author now.

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Dec 26, 2019

Thank you very much.

@JohannesLorenz
Copy link
Contributor

@BaraMGB Let's re-target this to master. Is it OK for you if I change the PR base? (Or you can also do it yourself)

Also, as this is not urgent anymore, I give the authorship of this PR back to you.

@JohannesLorenz JohannesLorenz changed the base branch from stable-1.2 to master January 8, 2020 06:17
@JohannesLorenz
Copy link
Contributor

OK, I just changed the base myself. It's now targeting master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playing Sample Track inside BB Track does not always work
6 participants