Issue #9: Add item selectors for translation migrations to skip impor…

…t if titles are empty.
LOBsTerr · May 3, 2023 · 587df49 · 587df49
1 parent 9d9536e
commit 587df49
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 36 deletions.
diff --git a/modules/newsroom_connector_country/src/Plugin/migrate/NewsroomCountryLanguageDeriver.php b/modules/newsroom_connector_country/src/Plugin/migrate/NewsroomCountryLanguageDeriver.php
@@ -16,17 +16,18 @@ class NewsroomCountryLanguageDeriver extends BaseNewsroomLanguageDeriver {
   protected function getDerivativeValues(array $base_plugin_definition, LanguageInterface $language, $language_code) {
     $language_id = $language->getId();
 
+    $base_plugin_definition['source']['item_selector'] = '//channel/item[string-length(title[@lang="' . $language_code . '"]) > 0]';
+
     // Name.
     $base_plugin_definition['source']['fields'][] = [
       'name' => 'name',
       'label' => 'Name',
       'selector' => 'title[@lang="' . $language_code . '"]/text()',
     ];
 
-    $base_plugin_definition['process']['name'] = [
-      'plugin' => 'skip_on_empty',
-      'source' => 'name',
-      'method' => 'row',
+    $base_plugin_definition['process']['name'][] = [
+      'plugin' => 'get',
+      'source' => "type_name_$language_id",
       'language' => $language_id,
     ];
 

diff --git a/modules/newsroom_connector_item/migrations/migrate_plus.migration.newsroom_item.yml b/modules/newsroom_connector_item/migrations/migrate_plus.migration.newsroom_item.yml
@@ -178,6 +178,7 @@ source:
       name: documents_match_language
       label: 'Documents match language'
       selector: 'infsonewsroom:docMatchLanguage/text()'
+
 process:
 
   type:

diff --git a/modules/newsroom_connector_item/src/Plugin/migrate/NewsroomItemImageMediaLanguageDeriver.php b/modules/newsroom_connector_item/src/Plugin/migrate/NewsroomItemImageMediaLanguageDeriver.php
@@ -6,7 +6,7 @@
 use Drupal\newsroom_connector\Plugin\migrate\BaseNewsroomLanguageDeriver;
 
 /**
- * Deriver for the newsroom item translations.
+ * Deriver for the newsroom item media translations.
  */
 class NewsroomItemImageMediaLanguageDeriver extends BaseNewsroomLanguageDeriver {
 
@@ -15,6 +15,7 @@ class NewsroomItemImageMediaLanguageDeriver extends BaseNewsroomLanguageDeriver
    */
   protected function getDerivativeValues(array $base_plugin_definition, LanguageInterface $language, $language_code) {
     $language_id = $language->getId();
+    $base_plugin_definition['source']['item_selector'] = '//channel/item[string-length(infsonewsroom:PicTitle[@lang="' . $language_code . '"]) > 0 and enclosure[@lang="' . $language_code . '" and @nrdoctype="image" and string-length(@url) > 0]]';
 
     $base_plugin_definition['process']['langcode'] = [
       'plugin' => 'default_value',
@@ -28,12 +29,6 @@ protected function getDerivativeValues(array $base_plugin_definition, LanguageIn
       'selector' => 'infsonewsroom:PicTitle[@lang="' . $language_code . '"]/text()',
     ];
 
-    $base_plugin_definition['process']['name'][] = [
-      'plugin' => 'skip_on_empty',
-      'method' => 'row',
-      'source' => 'image_name',
-    ];
-
     $base_plugin_definition['process']['name'][] = [
       'plugin' => 'get',
       'source' => 'image_name',

diff --git a/...es/newsroom_connector_newsletter/src/Plugin/migrate/NewsroomNewsletterLanguageDeriver.php b/...es/newsroom_connector_newsletter/src/Plugin/migrate/NewsroomNewsletterLanguageDeriver.php
@@ -16,17 +16,18 @@ class NewsroomNewsletterLanguageDeriver extends BaseNewsroomLanguageDeriver {
   protected function getDerivativeValues(array $base_plugin_definition, LanguageInterface $language, $language_code) {
     $language_id = $language->getId();
 
+    $base_plugin_definition['source']['item_selector'] = '//channel/item[string-length(title[@lang="' . $language_code . '"]) > 0]';
+
     // Name.
     $base_plugin_definition['source']['fields'][] = [
       'name' => 'name',
       'label' => 'Name',
       'selector' => 'title[@lang="' . $language_code . '"]/text()',
     ];
 
-    $base_plugin_definition['process']['name'] = [
-      'plugin' => 'skip_on_empty',
-      'source' => 'name',
-      'method' => 'row',
+    $base_plugin_definition['process']['name'][] = [
+      'plugin' => 'get',
+      'source' => "type_name_$language_id",
       'language' => $language_id,
     ];
 

diff --git a/modules/newsroom_connector_service/src/Plugin/migrate/NewsroomServiceLanguageDeriver.php b/modules/newsroom_connector_service/src/Plugin/migrate/NewsroomServiceLanguageDeriver.php
@@ -16,6 +16,8 @@ class NewsroomServiceLanguageDeriver extends BaseNewsroomLanguageDeriver {
   protected function getDerivativeValues(array $base_plugin_definition, LanguageInterface $language, $language_code) {
     $language_id = $language->getId();
 
+    $base_plugin_definition['source']['item_selector'] = '//channel/item[string-length(title[@lang="' . $language_code . '"]) > 0]';
+
     $base_plugin_definition['process']['langcode'] = [
       'plugin' => 'default_value',
       'default_value' => $language_id,
@@ -28,12 +30,6 @@ protected function getDerivativeValues(array $base_plugin_definition, LanguageIn
       'selector' => 'title[@lang="' . $language_code . '"]/text()',
     ];
 
-    $base_plugin_definition['process']['name'][] = [
-      'plugin' => 'skip_on_empty',
-      'source' => "service_name_$language_id",
-      'method' => 'row',
-    ];
-
     $base_plugin_definition['process']['name'][] = [
       'plugin' => 'get',
       'source' => "service_name_$language_id",

diff --git a/..._connector_team_responsible/src/Plugin/migrate/NewsroomTeamResponsibleLanguageDeriver.php b/..._connector_team_responsible/src/Plugin/migrate/NewsroomTeamResponsibleLanguageDeriver.php
@@ -16,17 +16,18 @@ class NewsroomTeamResponsibleLanguageDeriver extends BaseNewsroomLanguageDeriver
   protected function getDerivativeValues(array $base_plugin_definition, LanguageInterface $language, $language_code) {
     $language_id = $language->getId();
 
+    $base_plugin_definition['source']['item_selector'] = '//channel/item[string-length(title[@lang="' . $language_code . '"]) > 0]';
+
     // Name.
     $base_plugin_definition['source']['fields'][] = [
       'name' => "name",
       'label' => "Name",
       'selector' => 'title[@lang="' . $language_code . '"]/text()',
     ];
 
-    $base_plugin_definition['process']['name'] = [
-      'plugin' => 'skip_on_empty',
-      'source' => "name",
-      'method' => 'row',
+    $base_plugin_definition['process']['name'][] = [
+      'plugin' => 'get',
+      'source' => "topic_name_$language_id",
       'language' => $language_id,
     ];
 

diff --git a/modules/newsroom_connector_topic/src/Plugin/migrate/NewsroomTopicLanguageDeriver.php b/modules/newsroom_connector_topic/src/Plugin/migrate/NewsroomTopicLanguageDeriver.php
@@ -16,19 +16,15 @@ class NewsroomTopicLanguageDeriver extends BaseNewsroomLanguageDeriver {
   protected function getDerivativeValues(array $base_plugin_definition, LanguageInterface $language, $language_code) {
     $language_id = $language->getId();
 
+    $base_plugin_definition['source']['item_selector'] = '//channel/item[string-length(title[@lang="' . $language_code . '"]) > 0]';
+
     // Name.
     $base_plugin_definition['source']['fields'][] = [
       'name' => "topic_name_$language_id",
       'label' => "Topic name - $language_id",
       'selector' => 'title[@lang="' . $language_code . '"]/text()',
     ];
 
-    $base_plugin_definition['process']['name'][] = [
-      'plugin' => 'skip_on_empty',
-      'source' => "topic_name_$language_id",
-      'method' => 'row',
-    ];
-
     $base_plugin_definition['process']['name'][] = [
       'plugin' => 'get',
       'source' => "topic_name_$language_id",

diff --git a/modules/newsroom_connector_type/src/Plugin/migrate/NewsroomTypeLanguageDeriver.php b/modules/newsroom_connector_type/src/Plugin/migrate/NewsroomTypeLanguageDeriver.php
@@ -16,17 +16,14 @@ class NewsroomTypeLanguageDeriver extends BaseNewsroomLanguageDeriver {
   protected function getDerivativeValues(array $base_plugin_definition, LanguageInterface $language, $language_code) {
     $language_id = $language->getId();
 
+    $base_plugin_definition['source']['item_selector'] = '//channel/item[string-length(title[@lang="' . $language_code . '"]) > 0]';
+
     $base_plugin_definition['source']['fields'][] = [
       'name' => "type_name_$language_id",
       'label' => "Type name - $language_id",
       'selector' => 'title[@lang="' . $language_code . '"]/text()',
     ];
 
-    $base_plugin_definition['process']['name'][] = [
-      'plugin' => 'skip_on_empty',
-      'method' => 'row',
-      'source' => "type_name_$language_id",
-    ];
     $base_plugin_definition['process']['name'][] = [
       'plugin' => 'get',
       'source' => "type_name_$language_id",