Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularizacion RS1 #5

Open
wants to merge 123 commits into
base: main
Choose a base branch
from
Open

Modularizacion RS1 #5

wants to merge 123 commits into from

Conversation

lizloang
Copy link

@lizloang lizloang commented Oct 3, 2022

No description provided.

lizloang and others added 30 commits August 25, 2022 16:27
add a new folder named Components, add import and export welcome func…
add hover to register and login buttons
Show buttons (login and register)
creates footer and div container for main and footer
adds register route and insert all elements to the DOM
add view style create account
Add auth, email and password
Copy link
Collaborator

@reloadercf reloadercf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@@ -0,0 +1,316 @@
import { getAuth } from 'https://www.gstatic.com/firebasejs/9.9.3/firebase-auth.js';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿¿??

Comment on lines +57 to +94
// NEW POST
// Div new Post
const postDiv = document.createElement('div');
postDiv.setAttribute('class', 'post-input');
// Div input
const inputDiv = document.createElement('div');
inputDiv.setAttribute('class', 'input-feed');
// Img input
const inputImg = document.createElement('img');
inputImg.src = '../img/user-img.png';
inputImg.setAttribute('class', 'userimg-feed');
// input
const createPost = document.createElement('textarea');
createPost.setAttribute('cols', '40');
createPost.setAttribute('rows', '2');
createPost.setAttribute('placeholder', 'Ask to your partner...');
createPost.setAttribute('class', 'newpost-feed');
createPost.setAttribute('id', 'inputpost-feed');
// icon
const writeIcon = document.createElement('img');
writeIcon.src = '../img/write-icon.png';
writeIcon.setAttribute('class', 'writeicon-feed');
inputDiv.append(inputImg, createPost, writeIcon);
// Container button
const containerButton = document.createElement('div');
containerButton.setAttribute('class', 'containerbutton-feed');
// Msg Error
const msgError = document.createElement('div');
msgError.setAttribute('class', 'msgerror-feed');
msgError.textContent = 'Please, write something';
// Container divs post
const containerDivs = document.createElement('div');
containerDivs.setAttribute('class', 'container-posts');
// share button
const shareButton = document.createElement('button');
shareButton.setAttribute('class', 'sharebutton-feed');
shareButton.textContent = 'Share';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esto podría estar en otro archivo
NewPost.js
const NewPost =()=>{
}

Suggested change
// NEW POST
// Div new Post
const postDiv = document.createElement('div');
postDiv.setAttribute('class', 'post-input');
// Div input
const inputDiv = document.createElement('div');
inputDiv.setAttribute('class', 'input-feed');
// Img input
const inputImg = document.createElement('img');
inputImg.src = '../img/user-img.png';
inputImg.setAttribute('class', 'userimg-feed');
// input
const createPost = document.createElement('textarea');
createPost.setAttribute('cols', '40');
createPost.setAttribute('rows', '2');
createPost.setAttribute('placeholder', 'Ask to your partner...');
createPost.setAttribute('class', 'newpost-feed');
createPost.setAttribute('id', 'inputpost-feed');
// icon
const writeIcon = document.createElement('img');
writeIcon.src = '../img/write-icon.png';
writeIcon.setAttribute('class', 'writeicon-feed');
inputDiv.append(inputImg, createPost, writeIcon);
// Container button
const containerButton = document.createElement('div');
containerButton.setAttribute('class', 'containerbutton-feed');
// Msg Error
const msgError = document.createElement('div');
msgError.setAttribute('class', 'msgerror-feed');
msgError.textContent = 'Please, write something';
// Container divs post
const containerDivs = document.createElement('div');
containerDivs.setAttribute('class', 'container-posts');
// share button
const shareButton = document.createElement('button');
shareButton.setAttribute('class', 'sharebutton-feed');
shareButton.textContent = 'Share';
const newPost = NewPost()
fatherOfAll.apend(newPost)

shareButton.setAttribute('class', 'sharebutton-feed');
shareButton.textContent = 'Share';

// ALL POSTS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lo mismo con esto

Comment on lines +1 to +4
/* eslint-disable no-shadow */
/* eslint-disable no-undef */
/* eslint-disable import/no-unresolved */
/* eslint-disable max-len */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mejor reglas ¿No?

src/lib/Auth.js Outdated
import {
getAuth, createUserWithEmailAndPassword, signInWithEmailAndPassword, GoogleAuthProvider, signInWithRedirect,
getRedirectResult, GithubAuthProvider, signOut,
} from 'https://www.gstatic.com/firebasejs/9.9.3/firebase-auth.js';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en imports

src/lib/Auth.js Outdated
Comment on lines 27 to 39
/* // UPDATE INFO
export const updateInfo = (name) => updateProfile(auth.currentUser, {
displayName: name,
}).then(() => {
// Profile updated!
// ...
console.log('name updated');
}).catch((error) => {
// An error occurred
// ...
console.log('no name');
});
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si no se usa borralo

Suggested change
/* // UPDATE INFO
export const updateInfo = (name) => updateProfile(auth.currentUser, {
displayName: name,
}).then(() => {
// Profile updated!
// ...
console.log('name updated');
}).catch((error) => {
// An error occurred
// ...
console.log('no name');
});
*/

@@ -0,0 +1,13 @@
import { initializeApp } from 'https://www.gstatic.com/firebasejs/9.9.3/firebase-app.js';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

las voy a hackear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants