Move healthcheck from Dockerfile to docker-compose because it's optional

Launacloud · Feb 23, 2021 · 20ec435 · 20ec435
1 parent 53cd369
commit 20ec435
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/contrib/docker-compose/basic.yml b/contrib/docker-compose/basic.yml
@@ -16,6 +16,9 @@ services:
       - ADMIN_USERNAME=admin
       - ADMIN_PASSWORD=test123
       - DEBUG=1
+    # Optional health check:
+    # healthcheck:
+    #  test: ["CMD", "/usr/bin/miniflux", "-healthcheck", "auto"]
   db:
     image: postgres:latest
     container_name: postgres

diff --git a/packaging/docker/Dockerfile b/packaging/docker/Dockerfile
@@ -20,7 +20,6 @@ LABEL org.opencontainers.image.documentation=https://miniflux.app/docs/
 
 EXPOSE 8080
 ENV LISTEN_ADDR 0.0.0.0:8080
-HEALTHCHECK --start-period=30s CMD ["/usr/bin/miniflux", "-healthcheck", "auto"]
 RUN apk --no-cache add ca-certificates tzdata
 COPY --from=build /go/src/app/miniflux /usr/bin/miniflux
 USER nobody