EASY: printChild() should skip null nodes

Summary: `printChild()` can occasionally be called with a null node. Do nothing in that case. Reviewed By: neildhar Differential Revision: D25452839 fbshipit-source-id: c2c2e148e2903c18ff473f06d6988a8876ebc32d
Lauweal · Dec 10, 2020 · 2cfee04 · 2cfee04
1 parent 883bb94
commit 2cfee04
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/lib/AST2JS/AST2JS.cpp b/lib/AST2JS/AST2JS.cpp
@@ -742,6 +742,8 @@ class GenJS {
   }
 
   void printChild(Node *child, Node *parent, ChildPos childPosition) {
+    if (!child)
+      return;
     printParens(child, parent, needParens(parent, child, childPosition));
   }
 

diff --git a/test/AST2JS/input1-p.js.txt b/test/AST2JS/input1-p.js.txt
@@ -15,6 +15,7 @@ do
 while (i < 10);
 for(a in b in c)
   ++a;
+for(;;) {}
 try {
   1;
 } catch (e) {}

diff --git a/test/AST2JS/input1.js.txt b/test/AST2JS/input1.js.txt
@@ -25,6 +25,7 @@ while (i < 10);
 
 for(a in b in c)
     ++a;
+for(;;) {}
 
 try { 1; } catch (e) {}
-Original file line number
+Diff line change
@@ Expand Up / @@ -742,6 +742,8 @@ class GenJS { @@
       }
       void printChild(Node *child, Node *parent, ChildPos childPosition) {
+        if (!child)
+          return;
         printParens(child, parent, needParens(parent, child, childPosition));
       }
@@ Expand Down @@