feat: add update socket function #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
reviewed
Feb 3, 2025
pablodeymo
approved these changes
Feb 4, 2025
|
Please sync with main and update the changelog! |
@MegaRedHand Done in 420eb41 and cc8430f! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Adds update socket function, that was implemented in Go SDK but not in this. Also adds a simple test case.
Note: Since changelog is not implemented yet in
devbranch, PR #251 should be merged first, and then there should be created a PR that copies the changelog file from main branch to dev.Reviewer Checklist
changelog-Xlabels (if applies)