Merge pull request #80 from LedgerHQ/y333_091224/fix_color_inversion

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.5.2] - 2024-12-09
+
+### Fixed
+
+- For Nano S+ and X, B&W color shall be inverted
+
 ## [0.5.1] - 2024-08-23
 
 ### Fixed

ledgerwallet/manifest.py

@@ -17,7 +17,7 @@ def is_power2(n):
     return n != 0 and ((n & (n - 1)) == 0)
 
 
-def _image_to_buffer_nbgl(im: Image, compress: bool) -> bytes:
+def _image_to_buffer_nbgl(im: Image, compress: bool, reverse_1bpp: bool) -> bytes:
     im = im.convert("L")
     nb_colors = len(im.getcolors())
 
@@ -59,6 +59,9 @@ def _image_to_buffer_nbgl(im: Image, compress: bool) -> bytes:
             if color_index >= nb_colors:
                 color_index = nb_colors - 1
 
+            if bpp == 1 and reverse_1bpp:
+                color_index = (color_index + 1) & 0x1
+
             # le encoded
             current_byte += color_index << ((8 - bpp) - current_bit)
             current_bit += bpp
@@ -199,7 +202,7 @@ def icon_from_file(image_file: str, device: str, api_level: Optional[int]) -> by
         DeviceNames.LEDGER_STAX.value,
         DeviceNames.LEDGER_FLEX.value,
     ]:
-        image_data = _image_to_buffer_nbgl(im, True)
+        image_data = _image_to_buffer_nbgl(im, True, False)
 
     elif (
         get_device_name(int(device, 16))
@@ -210,7 +213,7 @@ def icon_from_file(image_file: str, device: str, api_level: Optional[int]) -> by
         and api_level is not None
         and api_level > 5
     ):
-        image_data = _image_to_buffer_nbgl(im, False)
+        image_data = _image_to_buffer_nbgl(im, False, True)
     else:
         image_data = _image_to_packed_buffer_bagl(im)