Refactoring

Lee66 · May 6, 2018 · 2d073d6 · 2d073d6
1 parent 04a94d6
commit 2d073d6
Showing 1 changed file with 39 additions and 19 deletions.
diff --git a/src/Writer/PngWriter.php b/src/Writer/PngWriter.php
@@ -21,25 +21,7 @@ public function writeString(QrCodeInterface $qrCode): string
     {
         $data = $this->getData($qrCode);
 
-        $baseSize = $qrCode->getRoundBlockSize() ? $data['block_size'] : 25;
-        $baseImage = imagecreatetruecolor($data['block_count'] * $baseSize, $data['block_count'] * $baseSize);
-        $foregroundColor = imagecolorallocatealpha($baseImage, $qrCode->getForegroundColor()['r'], $qrCode->getForegroundColor()['g'], $qrCode->getForegroundColor()['b'], $qrCode->getForegroundColor()['a']);
-        $backgroundColor = imagecolorallocatealpha($baseImage, $qrCode->getBackgroundColor()['r'], $qrCode->getBackgroundColor()['g'], $qrCode->getBackgroundColor()['b'], $qrCode->getBackgroundColor()['a']);
-        imagefill($baseImage, 0, 0, $backgroundColor);
-
-        foreach ($data['matrix'] as $row => $values) {
-            foreach ($values as $column => $value) {
-                if (1 === $value) {
-                    imagefilledrectangle($baseImage, $column * $baseSize, $row * $baseSize, ($column + 1) * $baseSize, ($row + 1) * $baseSize, $foregroundColor);
-                }
-            }
-        }
-
-        $image = imagecreatetruecolor($data['outer_width'], $data['outer_height']);
-        $backgroundColor = imagecolorallocatealpha($image, $qrCode->getBackgroundColor()['r'], $qrCode->getBackgroundColor()['g'], $qrCode->getBackgroundColor()['b'], $qrCode->getBackgroundColor()['a']);
-        imagefill($image, 0, 0, $backgroundColor);
-
-        imagecopyresampled($image, $baseImage, $data['margin_left'], $data['margin_left'], 0, 0, $data['inner_width'], $data['inner_height'], $baseSize * $data['block_count'], $baseSize * $data['block_count']);
+        $image = $this->createImage($data, $qrCode);
 
         if ($qrCode->getLogoPath()) {
             $image = $this->addLogo($image, $qrCode->getLogoPath(), $qrCode->getLogoWidth());
@@ -64,6 +46,44 @@ public function writeString(QrCodeInterface $qrCode): string
         return $string;
     }
 
+    private function createImage(array $data, QrCodeInterface $qrCode)
+    {
+        $baseSize = $qrCode->getRoundBlockSize() ? $data['block_size'] : 25;
+
+        $baseImage = $this->createBaseImage($baseSize, $data, $qrCode);
+        $interpolatedImage = $this->createInterpolatedImage($baseImage, $data, $qrCode);
+
+        return $interpolatedImage;
+    }
+
+    private function createBaseImage(int $baseSize, array $data, QrCodeInterface $qrCode)
+    {
+        $image = imagecreatetruecolor($data['block_count'] * $baseSize, $data['block_count'] * $baseSize);
+        $foregroundColor = imagecolorallocatealpha($image, $qrCode->getForegroundColor()['r'], $qrCode->getForegroundColor()['g'], $qrCode->getForegroundColor()['b'], $qrCode->getForegroundColor()['a']);
+        $backgroundColor = imagecolorallocatealpha($image, $qrCode->getBackgroundColor()['r'], $qrCode->getBackgroundColor()['g'], $qrCode->getBackgroundColor()['b'], $qrCode->getBackgroundColor()['a']);
+        imagefill($image, 0, 0, $backgroundColor);
+
+        foreach ($data['matrix'] as $row => $values) {
+            foreach ($values as $column => $value) {
+                if (1 === $value) {
+                    imagefilledrectangle($image, $column * $baseSize, $row * $baseSize, ($column + 1) * $baseSize, ($row + 1) * $baseSize, $foregroundColor);
+                }
+            }
+        }
+
+        return $image;
+    }
+
+    private function createInterpolatedImage($baseImage, array $data, QrCodeInterface $qrCode)
+    {
+        $image = imagecreatetruecolor($data['outer_width'], $data['outer_height']);
+        $backgroundColor = imagecolorallocatealpha($image, $qrCode->getBackgroundColor()['r'], $qrCode->getBackgroundColor()['g'], $qrCode->getBackgroundColor()['b'], $qrCode->getBackgroundColor()['a']);
+        imagefill($image, 0, 0, $backgroundColor);
+        imagecopyresampled($image, $baseImage, $data['margin_left'], $data['margin_left'], 0, 0, $data['inner_width'], $data['inner_height'], imagesx($baseImage), imagesy($baseImage));
+
+        return $image;
+    }
+
     private function addLogo($sourceImage, string $logoPath, int $logoWidth = null)
     {
         $logoImage = imagecreatefromstring(file_get_contents($logoPath));