[fix] path in HttpProxies html file was wrong

LeiDeMing · Mar 2, 2017 · f5c3610 · f5c3610
1 parent 26ab0dc
commit f5c3610
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/...ssons/http-proxies/src/main/java/org/owasp/webgoat/plugin/HttpBasicsInterceptRequest.java b/...ssons/http-proxies/src/main/java/org/owasp/webgoat/plugin/HttpBasicsInterceptRequest.java
@@ -49,10 +49,15 @@ public class HttpBasicsInterceptRequest extends AssignmentEndpoint {
 	@RequestMapping(method = RequestMethod.GET)
 	public @ResponseBody
 	AttackResult completed(HttpServletRequest request) throws IOException {
-		if (request.getHeader("x-request-intercepted").toLowerCase().equals("true") && request.getParameter("changeMe").equals("Requests are tampered easily")) {
+		String header = null;
+		String param = null;
+		if (request != null && (header = request.getHeader("x-request-intercepted")) != null
+			&& header.toLowerCase().equals("true") 
+			&& (param = request.getParameter("changeMe")) != null
+			&& param.equals("Requests are tampered easily")) {
             return trackProgress(success().feedback("http-proxies.intercept.success").build());
 		} else {
             return trackProgress(failed().feedback("http-proxies.intercept.failure").build());
         }
 	}
-}
+}
diff --git a/webgoat-lessons/http-proxies/src/main/resources/plugin/HttpProxies/html/HttpProxies.html b/webgoat-lessons/http-proxies/src/main/resources/plugin/HttpProxies/html/HttpProxies.html
@@ -37,7 +37,7 @@
             <div class="assignment-success"><i class="fa fa-2 fa-check hidden" aria-hidden="true"></i></div>
             <form class="attack-form" accept-charset="UNKNOWN" name="intercept-request"
                   method="POST"
-                  action="/WebGoat/HttpBasics/intercept-request"
+                  action="/WebGoat/HttpProxies/intercept-request"
                   enctype="application/json;charset=UTF-8">
 
                 <input type="text" value="doesn't matter really" name="changeMe" />
@@ -48,4 +48,4 @@
             <div class="attack-output"></div>
         </div>
     </div>
-</html>
+</html>