fix: proper parse Error message on Node 12 (puppeteer#4698)

Check message prefix rather than strict equality when detecting circular JSON error. The message format has changed in Node 12 which broke the condition and failed a test.
Leland · Jul 13, 2019 · 715aad2 · 715aad2
1 parent 49b2795
commit 715aad2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/experimental/puppeteer-firefox/lib/ExecutionContext.js b/experimental/puppeteer-firefox/lib/ExecutionContext.js
@@ -67,7 +67,7 @@ class ExecutionContext {
         executionContextId: this._executionContextId
       });
     } catch (err) {
-      if (err instanceof TypeError && err.message === 'Converting circular structure to JSON')
+      if (err instanceof TypeError && err.message.startsWith('Converting circular structure to JSON'))
         err.message += ' Are you passing a nested JSHandle?';
       throw err;
     }

diff --git a/lib/ExecutionContext.js b/lib/ExecutionContext.js
@@ -113,7 +113,7 @@ class ExecutionContext {
         userGesture: true
       });
     } catch (err) {
-      if (err instanceof TypeError && err.message === 'Converting circular structure to JSON')
+      if (err instanceof TypeError && err.message.startsWith('Converting circular structure to JSON'))
         err.message += ' Are you passing a nested JSHandle?';
       throw err;
     }