Skip to content

Commit

Permalink
修复派生Pack类型时无法自动排除原Pack,会导致同一模块出现两个Pack的问题,自动排除基类中Pack类 fixed dotnetco…
Browse files Browse the repository at this point in the history
  • Loading branch information
gmf520 committed Apr 25, 2019
1 parent 01ec995 commit 73a7470
Show file tree
Hide file tree
Showing 9 changed files with 27 additions and 15 deletions.
2 changes: 1 addition & 1 deletion build/build-docs.bat
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
docfx metadata ../osharp-ns20.sln
docfx metadata ../osharp.sln
apicleaner.exe _api
docfx docfx.json
docfx serve _site
2 changes: 1 addition & 1 deletion docs/build-docs.bat
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
docfx metadata ../osharp-ns20.sln
docfx metadata ../osharp.sln
apicleaner.exe _api
docfx docfx.json
docfx serve _site
1 change: 0 additions & 1 deletion docs/docfx.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"files": [
"articles/**.md",
"articles/**/toc.yml",
"toc.yml",
"*.md"
]
}
Expand Down
5 changes: 0 additions & 5 deletions docs/toc.yml

This file was deleted.

5 changes: 5 additions & 0 deletions docs/toc.yml.bak
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
- name: 返回文档中心
href: /
- name: API文档
href: api/
homepage: api/index.md
17 changes: 17 additions & 0 deletions src/OSharp/Core/Packs/OSharpPackTypeFinder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
// <last-date>2018-08-09 22:22</last-date>
// -----------------------------------------------------------------------

using System;
using System.Collections.Generic;
using System.Linq;

using OSharp.Collections;
using OSharp.Reflection;


Expand All @@ -23,5 +28,17 @@ public class OsharpPackTypeFinder : BaseTypeFinderBase<OsharpPack>, IOsharpPackT
public OsharpPackTypeFinder(IAllAssemblyFinder allAssemblyFinder)
: base(allAssemblyFinder)
{ }

/// <summary>
/// 重写以实现所有项的查找
/// </summary>
/// <returns></returns>
protected override Type[] FindAllItems()
{
//排除被继承的Pack实类
Type[] types = base.FindAllItems();
Type[] basePackTypes = types.Select(m => m.BaseType).Where(m => m != null && m.IsClass && !m.IsAbstract).ToArray();
return types.Except(basePackTypes).ToArray();
}
}
}
4 changes: 2 additions & 2 deletions src/OSharp/EventBuses/EventHandlerBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public virtual void Handle(IEventData eventData)
/// <param name="eventData">事件源数据</param>
/// <param name="cancelToken">异步取消标识</param>
/// <returns></returns>
public virtual Task HandleAsync(IEventData eventData, CancellationToken cancelToken = default)
public virtual Task HandleAsync(IEventData eventData, CancellationToken cancelToken = default(CancellationToken))
{
if (!CanHandle(eventData))
{
Expand All @@ -68,7 +68,7 @@ public virtual Task HandleAsync(IEventData eventData, CancellationToken cancelTo
/// <param name="eventData">事件源数据</param>
/// <param name="cancelToken">异步取消标识</param>
/// <returns>是否成功</returns>
public virtual Task HandleAsync(TEventData eventData, CancellationToken cancelToken = default)
public virtual Task HandleAsync(TEventData eventData, CancellationToken cancelToken = default(CancellationToken))
{
return Task.Run(() => Handle(eventData), cancelToken);
}
Expand Down
4 changes: 0 additions & 4 deletions tests/web/Liuliu.Demo.Web/Startups/SignalrPack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ namespace Liuliu.Demo.Web.Startups
[Description("SignalR模块")]
public class SignalRPack : SignalRPackBase
{
#region Overrides of SignalRPackBase

/// <summary>
/// 重写以获取Hub路由创建委托
/// </summary>
Expand All @@ -36,7 +34,5 @@ protected override Action<HubRouteBuilder> GetHubRouteBuildAction(IServiceProvid
// 例如:builder.MapHub<MyHub>();
});
}

#endregion
}
}
2 changes: 1 addition & 1 deletion tests/web/Liuliu.Demo.Web/appsettings.Development.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
},
"Redis": {
"Configuration": "localhost",
"InstanceName": "OSharpDemo",
"InstanceName": "OSharpDemo:",
"Enabled": false
},
"Swagger": {
Expand Down

0 comments on commit 73a7470

Please sign in to comment.