Skip to content

Commit

Permalink
Edits for docs (#883)
Browse files Browse the repository at this point in the history
* Docs updates

* Exclude docs branch from gh-wf
  • Loading branch information
CBroz1 authored Mar 21, 2024
1 parent 3de6cdc commit e858cae
Show file tree
Hide file tree
Showing 8 changed files with 33 additions and 9 deletions.
10 changes: 9 additions & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,20 @@ A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:

1. This error is on file '....' at file path '....'
2. Click on '....'
3. Scroll down to '....'
4. See error

</details><summary>Error Stack</summary>

```python
# Paste the error stack trace here
```

</details>

**Expected behavior**
A clear and concise description of what you expected to happen.

Expand All @@ -25,4 +34,3 @@ If applicable, add screenshots to help explain your problem.

**Additional context**
Add any other context about the problem here.

6 changes: 5 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: Lint

on: [push, pull_request]
on:
push:
branches:
- '!documentation'
pull_request:

jobs:
black:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Deploy
run: |
FULL_VERSION=${{ github.ref }}
FULL_VERSION=${{ github.ref_name }}
export MAJOR_VERSION=${FULL_VERSION:0:3}
echo "OWNER: ${REPO_OWNER}. BUILD: ${MAJOR_VERSION}"
bash ./docs/build-docs.sh push $REPO_OWNER
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-conda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- '!test_branch'
- '!documentation'
schedule: # once a day at midnight UTC
- cron: '0 0 * * *'

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-package-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
- master
- maint/*
- '!test_branch'
- '!documentation'
tags:
- "*"
pull_request:
Expand Down
1 change: 1 addition & 0 deletions docs/build-docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
cp ./CHANGELOG.md ./docs/src/
cp ./LICENSE ./docs/src/LICENSE.md
mkdir -p ./docs/src/notebooks
rm -r ./docs/src/notebooks/*
cp ./notebooks/*ipynb ./docs/src/notebooks/
cp ./notebooks/*md ./docs/src/notebooks/
mv ./docs/src/notebooks/README.md ./docs/src/notebooks/index.md
Expand Down
14 changes: 11 additions & 3 deletions notebooks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@ Decoding can be from sorted or from unsorted data using spike waveform features
(so-called clusterless decoding).

The first notebook
([Extracting Clusterless Waveform Features](./41_Extracting_Clusterless_Waveform_Features.ipynb))
([Extracting Clusterless Waveform Features](./40_Extracting_Clusterless_Waveform_Features.ipynb))
in this series shows how to retrieve the spike waveform features used for
clusterless decoding.

The second notebook ([Clusterless Decoding](./42_Decoding_Clusterless.ipynb))
The second notebook ([Clusterless Decoding](./41_Decoding_Clusterless.ipynb))
shows a detailed example of how to decode the position of the animal from the
spike waveform features. The third notebook
([Decoding](./43_Decoding_SortedSpikes.ipynb)) shows how to decode the position
([Decoding](./42_Decoding_SortedSpikes.ipynb)) shows how to decode the position
of the animal from the sorted spikes.

## Developer note
Expand All @@ -79,3 +79,11 @@ black .
```

Unfortunately, jupytext-generated py script are not black-compliant by default.

You can ensure black compliance with the `pre-commit` hook by running

```bash
pip install pre-commit
```

This will run black whenever you commit changes to the repository.
7 changes: 4 additions & 3 deletions src/spyglass/position/v1/position_dlc_pose_estimation.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,10 @@ def insert_estimation_task(
Parameters
----------
key: DataJoint key specifying a pairing of VideoRecording and Model.
task_mode (bool): Default 'trigger' computation.
Or 'load' existing results.
key: dict
DataJoint key specifying a pairing of VideoRecording and Model.
task_mode: bool, optional
Default 'trigger' computation. Or 'load' existing results.
params (dict): Optional. Parameters passed to DLC's analyze_videos:
videotype, gputouse, save_as_csv, batchsize, cropping,
TFGPUinference, dynamic, robust_nframes, allow_growth, use_shelve
Expand Down

0 comments on commit e858cae

Please sign in to comment.