Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch_nwb non-mixin compatability #1201

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fetch_nwb non-mixin compatability #1201

merged 2 commits into from
Dec 19, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Dec 17, 2024 •
edited
Loading

Description

Fixes #1200 , #1185

  • adds check that the table is a SpyglassMixin class before using export args in join

Checklist:

  • N This PR should be accompanied by a release: (yes/no/unsure)
  • NA If release, I have updated the CITATION.cff
  • N This PR makes edits to table definitions: (yes/no)
  • NA If table edits, I have included an alter snippet for release notes.
  • NA If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • NA I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 marked this pull request as ready for review December 17, 2024 20:37
@samuelbray32 samuelbray32 requested a review from CBroz1 December 17, 2024 20:37
CBroz1
CBroz1 approved these changes Dec 19, 2024
View reviewed changes
src/spyglass/utils/dj_helper_fn.py
@@ -301,8 +303,16 @@ def fetch_nwb(query_expression, nwb_master, *attrs, **kwargs):
# This also opens the file and stores the file object
get_nwb_file(file_path)

# logging arg only if instanced table inherits Mixin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe at some point this inst piece should be extracted into a helper, or maybe as def is_spymixin(obj) -> bool: - but i'm good with merging as-is

@edeno edeno merged commit 36bd132 into master Dec 19, 2024
17 checks passed
@edeno edeno deleted the 1200_fix branch December 19, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fetch_nwb assumes fetching table inherits Mixin
3 participants
@samuelbray32 @CBroz1 @edeno