Skip to content

Commit

Permalink
interconnect: qcom: rpm: Prevent integer overflow in rate
Browse files Browse the repository at this point in the history
Using icc-rpm on ARM32 currently results in clk_set_rate() errors during
boot, e.g. "bus clk_set_rate error: -22". This is very similar to commit
7381e27 ("interconnect: qcom: msm8974: Prevent integer overflow in rate")
where the u64 is converted to a signed long during clock rate rounding,
resulting in an overflow on 32-bit platforms.

Let's fix it similarly by making sure that the rate does not exceed
LONG_MAX. Such high clock rates will surely result in the maximum
frequency of the bus anyway.

Signed-off-by: Stephan Gerhold <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Georgi Djakov <[email protected]>
  • Loading branch information
stephan-gh authored and Georgi Djakov committed Dec 6, 2021
1 parent 42cdeb6 commit a7d9436
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/interconnect/qcom/icc-rpm.c
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
rate = max(sum_bw, max_peak_bw);

do_div(rate, qn->buswidth);
rate = min_t(u64, rate, LONG_MAX);

if (qn->rate == rate)
return 0;
Expand Down

0 comments on commit a7d9436

Please sign in to comment.