Skip to content

Commit

Permalink
locking/atomic: centralize generated headers
Browse files Browse the repository at this point in the history
The generated atomic headers are only intended to be included directly
by <linux/atomic.h>, but are spread across include/linux/ and
include/asm-generic/, where people mnay be encouraged to include them.

This patch centralizes them under include/linux/atomic/.

Other than the header guards and hashes, there is no change to any of
the generated headers as a result of this patch.

Signed-off-by: Mark Rutland <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
Mark Rutland authored and Peter Zijlstra committed Jul 16, 2021
1 parent f3e615b commit e3d18ce
Show file tree
Hide file tree
Showing 8 changed files with 23 additions and 24 deletions.
7 changes: 3 additions & 4 deletions include/linux/atomic.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,8 @@
__ret; \
})

#include <linux/atomic-arch-fallback.h>
#include <asm-generic/atomic-instrumented.h>

#include <asm-generic/atomic-long.h>
#include <linux/atomic/atomic-arch-fallback.h>
#include <linux/atomic/atomic-instrumented.h>
#include <linux/atomic/atomic-long.h>

#endif /* _LINUX_ATOMIC_H */
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
* arch_ variants (i.e. arch_atomic_read()/arch_atomic_cmpxchg()) to avoid
* double instrumentation.
*/
#ifndef _ASM_GENERIC_ATOMIC_INSTRUMENTED_H
#define _ASM_GENERIC_ATOMIC_INSTRUMENTED_H
#ifndef _LINUX_ATOMIC_INSTRUMENTED_H
#define _LINUX_ATOMIC_INSTRUMENTED_H

#include <linux/build_bug.h>
#include <linux/compiler.h>
Expand Down Expand Up @@ -1333,5 +1333,5 @@ atomic64_dec_if_positive(atomic64_t *v)
arch_cmpxchg_double_local(__ai_ptr, __VA_ARGS__); \
})

#endif /* _ASM_GENERIC_ATOMIC_INSTRUMENTED_H */
// 1d7c3a25aca5c7fb031c307be4c3d24c7b48fcd5
#endif /* _LINUX_ATOMIC_INSTRUMENTED_H */
// 5edd72f105b6f54b7e9492d794abee88e6912d29
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
// Generated by scripts/atomic/gen-atomic-long.sh
// DO NOT MODIFY THIS FILE DIRECTLY

#ifndef _ASM_GENERIC_ATOMIC_LONG_H
#define _ASM_GENERIC_ATOMIC_LONG_H
#ifndef _LINUX_ATOMIC_LONG_H
#define _LINUX_ATOMIC_LONG_H

#include <linux/compiler.h>
#include <asm/types.h>
Expand Down Expand Up @@ -1010,5 +1010,5 @@ atomic_long_dec_if_positive(atomic_long_t *v)
}

#endif /* CONFIG_64BIT */
#endif /* _ASM_GENERIC_ATOMIC_LONG_H */
// a624200981f552b2c6be4f32fe44da8289f30d87
#endif /* _LINUX_ATOMIC_LONG_H */
// c5552b5d78a0c7584dfd03cba985e78a1a86bbed
6 changes: 3 additions & 3 deletions scripts/atomic/check-atomics.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ if [ $? -ne 0 ]; then
fi

cat <<EOF |
asm-generic/atomic-instrumented.h
asm-generic/atomic-long.h
linux/atomic-arch-fallback.h
linux/atomic/atomic-instrumented.h
linux/atomic/atomic-long.h
linux/atomic/atomic-arch-fallback.h
EOF
while read header; do
OLDSUM="$(tail -n 1 ${LINUXDIR}/include/${header})"
Expand Down
6 changes: 3 additions & 3 deletions scripts/atomic/gen-atomic-instrumented.sh
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ cat << EOF
* arch_ variants (i.e. arch_atomic_read()/arch_atomic_cmpxchg()) to avoid
* double instrumentation.
*/
#ifndef _ASM_GENERIC_ATOMIC_INSTRUMENTED_H
#define _ASM_GENERIC_ATOMIC_INSTRUMENTED_H
#ifndef _LINUX_ATOMIC_INSTRUMENTED_H
#define _LINUX_ATOMIC_INSTRUMENTED_H
#include <linux/build_bug.h>
#include <linux/compiler.h>
Expand Down Expand Up @@ -158,5 +158,5 @@ gen_xchg "cmpxchg_double_local" "2 * "

cat <<EOF
#endif /* _ASM_GENERIC_ATOMIC_INSTRUMENTED_H */
#endif /* _LINUX_ATOMIC_INSTRUMENTED_H */
EOF
6 changes: 3 additions & 3 deletions scripts/atomic/gen-atomic-long.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ cat << EOF
// Generated by $0
// DO NOT MODIFY THIS FILE DIRECTLY
#ifndef _ASM_GENERIC_ATOMIC_LONG_H
#define _ASM_GENERIC_ATOMIC_LONG_H
#ifndef _LINUX_ATOMIC_LONG_H
#define _LINUX_ATOMIC_LONG_H
#include <linux/compiler.h>
#include <asm/types.h>
Expand Down Expand Up @@ -98,5 +98,5 @@ done

cat <<EOF
#endif /* CONFIG_64BIT */
#endif /* _ASM_GENERIC_ATOMIC_LONG_H */
#endif /* _LINUX_ATOMIC_LONG_H */
EOF
6 changes: 3 additions & 3 deletions scripts/atomic/gen-atomics.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ ATOMICTBL=${ATOMICDIR}/atomics.tbl
LINUXDIR=${ATOMICDIR}/../..

cat <<EOF |
gen-atomic-instrumented.sh asm-generic/atomic-instrumented.h
gen-atomic-long.sh asm-generic/atomic-long.h
gen-atomic-fallback.sh linux/atomic-arch-fallback.h
gen-atomic-instrumented.sh linux/atomic/atomic-instrumented.h
gen-atomic-long.sh linux/atomic/atomic-long.h
gen-atomic-fallback.sh linux/atomic/atomic-arch-fallback.h
EOF
while read script header args; do
/bin/sh ${ATOMICDIR}/${script} ${ATOMICTBL} ${args} > ${LINUXDIR}/include/${header}
Expand Down

0 comments on commit e3d18ce

Please sign in to comment.