Bugfix/Data inconsistency caused by updateEventHandler (Netflix#3843)

* remove previous index of event handlers by event if event handler's event gets updated * run ./gradlew spotlessApply
LuisLainez · Nov 12, 2023 · be790a4 · be790a4
1 parent 8981878
commit be790a4
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/redis-persistence/src/main/java/com/netflix/conductor/redis/dao/RedisEventHandlerDAO.java b/redis-persistence/src/main/java/com/netflix/conductor/redis/dao/RedisEventHandlerDAO.java
@@ -72,6 +72,9 @@ public void updateEventHandler(EventHandler eventHandler) {
             throw new NotFoundException(
                     "EventHandler with name %s not found!", eventHandler.getName());
         }
+        if (!existing.getEvent().equals(eventHandler.getEvent())) {
+            removeIndex(existing);
+        }
         index(eventHandler);
         jedisProxy.hset(nsKey(EVENT_HANDLERS), eventHandler.getName(), toJson(eventHandler));
         recordRedisDaoRequests("updateEventHandler");