FSP/NVRAM: Do not assert in vNVRAM statistics call

[ Upstream commit 9ca8bf1 ] `msg` is valid pointer here. I don't recall why I added assert here :-( This is not correct. We shouldn't call assert here. Also we are not using `msg`. Hence convert it to `__unused`. Fixes: 19d4f98 ('FSP/NVRAM: Handle "get vNVRAM statistics" command') Cc: [email protected] # v5.4.x + Signed-off-by: Vasant Hegde <[email protected]> Reviewed-by: Mahesh Salgaonkar <[email protected]> Signed-off-by: Oliver O'Halloran <[email protected]> Signed-off-by: Vasant Hegde <[email protected]>
LuluTHSu · Oct 22, 2020 · d3d0a34 · d3d0a34
1 parent 9a094b6
commit d3d0a34
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/hw/fsp/fsp-nvram.c b/hw/fsp/fsp-nvram.c
@@ -310,12 +310,11 @@ static struct fsp_client fsp_nvram_client_rr = {
 	.message = fsp_nvram_msg_rr,
 };
 
-static bool fsp_vnvram_msg(u32 cmd_sub_mod, struct fsp_msg *msg)
+static bool fsp_vnvram_msg(u32 cmd_sub_mod, struct fsp_msg *msg __unused)
 {
 	u32 cmd;
 	struct fsp_msg *resp;
 
-	assert(msg == NULL);
 	switch (cmd_sub_mod) {
 	case FSP_CMD_GET_VNV_STATS:
 		prlog(PR_DEBUG,