Skip to content

Commit

Permalink
When CLI changes, we also re-run K8S tests (apache#13305)
Browse files Browse the repository at this point in the history
Since K8S tests use Airflow CLI (via Helm Chart) we should
also run the K8S tests when CLI changes.

Fixes apache#12780
  • Loading branch information
potiuk authored Dec 24, 2020
1 parent e9d65bd commit e2bfac9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion PULL_REQUEST_WORKFLOW.rst
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ The logic implemented for the changes works as follows:
modifications to any Python code occurs. Example test of this type is verifying proper structure of
the project including proper naming of all files.
b) if any of the Airflow API files changed we enable ``API`` test type
c) if any of the Airflow CLI files changed we enable ``CLI`` test type
c) if any of the Airflow CLI files changed we enable ``CLI`` test type and Kubernetes tests (the
K8S tests depend on CLI changes as helm chart uses CLI to run Airflow).
d) if any of the Provider files changed we enable ``Providers`` test type
e) if any of the WWW files changed we enable ``WWW`` test type
f) if any of the Kubernetes files changed we enable ``Kubernetes`` test type
Expand Down
3 changes: 2 additions & 1 deletion scripts/ci/selective_ci_checks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -536,9 +536,10 @@ function calculate_test_types_to_run() {
fi
if [[ ${COUNT_CLI_CHANGED_FILES} != "0" ]]; then
echo
echo "Adding CLI to selected files as ${COUNT_CLI_CHANGED_FILES} CLI files changed"
echo "Adding CLI and Kubernetes (they depend on CLI) to selected files as ${COUNT_CLI_CHANGED_FILES} CLI files changed"
echo
SELECTED_TESTS="${SELECTED_TESTS} CLI"
kubernetes_tests_needed="true"
fi
if [[ ${COUNT_PROVIDERS_CHANGED_FILES} != "0" ]]; then
echo
Expand Down

0 comments on commit e2bfac9

Please sign in to comment.