Skip to content

Commit

Permalink
Add fixme for a missing guard on third consecutive texture request
Browse files Browse the repository at this point in the history
  • Loading branch information
SeaDve committed May 4, 2022
1 parent 0e9842f commit a89ca50
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/core/album_art_store/album_art.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ impl AlbumArt {
}

pub async fn texture(&self) -> anyhow::Result<&gdk::Texture> {
// FIXME this guard won't work if there would be three
// same time caller to this functions since the second
// one would take the receiver. Thus, there won't be a
// guard for the third one.
if let Some(receiver) = self.loading.take() {
// If there are currently loading AlbumArt, wait
// for it to finish and be stored before checking if
Expand Down

0 comments on commit a89ca50

Please sign in to comment.