Remove VALIDATE_ADDONS setting.

There's no need for it anymore.

settings.py

@@ -71,8 +71,6 @@
 SERVICES_DOMAIN = 'localhost:8000'
 SERVICES_URL = 'http://%s' % SERVICES_DOMAIN
 
-VALIDATE_ADDONS = True
-
 ADDON_COLLECTOR_ID = 1
 
 # Default AMO user id to use for tasks (from users.json fixture in zadmin).

settings_test.py

@@ -53,9 +53,6 @@ def _polite_tmpdir():
 # Turn off search engine indexing.
 USE_ELASTIC = False
 
-# Ensure all validation code runs in tests:
-VALIDATE_ADDONS = True
-
 PAYPAL_PERMISSIONS_URL = ''
 
 ENABLE_API_ERROR_SERVICE = False

src/olympia/devhub/tasks.py

@@ -355,13 +355,6 @@ def run_validator(path, for_appversions=None, test_all_tiers=False,
     Not all application versions will have a set of registered
     compatibility tests.
     """
-    if not settings.VALIDATE_ADDONS:
-        # This should only ever be set on development instances.
-        # Don't run the validator, just return a skeleton passing result set.
-        results = deepcopy(amo.VALIDATOR_SKELETON_RESULTS)
-        results['metadata']['listed'] = listed
-        return json.dumps(results)
-
     from validator.validate import validate
 
     apps = dump_apps.Command.JSON_PATH

src/olympia/lib/settings_base.py

@@ -1425,7 +1425,7 @@ def get_redis_settings(uri):
 # Full path or executable path (relative to $PATH) of the spidermonkey js
 # binary.  It must be a version compatible with amo-validator.
 SPIDERMONKEY = None
-VALIDATE_ADDONS = True
+
 # Number of seconds before celery tasks will abort addon validation:
 VALIDATOR_TIMEOUT = 110