Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Issue #67 scrolling placement error solved #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joanvila
Copy link

This pull request soves a problem that happens when there is a scroll in the page. When this happens, the datepicker much more below than it should.

The problem appears in the screenshot attached.

screen shot 2016-03-16 at 18 28 55

@andresmoschini
Copy link
Member

Thanks @joanvila, but previous code looks as a hack done to support a particular case, if we apply your fix we will probably break something else.

I will try to spend some time to research the possible problems.

@joanvila
Copy link
Author

Thank you for the response @andresmoschini
If I find something that breaks down with this solution I will tell it :)

@infocynic
Copy link

So it's been almost a year and a half... if nobody has found a reason to avoid adopting this fix, I suggest it be incorporated. Given that the demo page itself is broken, clearly there's a problem here, and this is an easy fix. It tests fine in Chrome, Firefox, IE 11, and Edge. If the previous fix was intended for a specific problem, it should have been documented, but as-is, it's just causing new problems, so should be removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants