Skip to content

Commit

Permalink
pybamm-team#1245 fix options
Browse files Browse the repository at this point in the history
  • Loading branch information
valentinsulzer committed Nov 30, 2020
1 parent ca6a9e5 commit 35d5988
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions pybamm/parameters/lithium_ion_parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ def D_n_dimensional(self, sto, T):
"""Dimensional diffusivity in negative particle. Note this is defined as a
function of stochiometry"""
inputs = {"Negative particle stoichiometry": sto, "Temperature [K]": T}
if self.options["particle cracking"] is not None:
if self.options["particle cracking"] != "none":
mech_effects = (
1 + self.theta_n_dim * (sto * self.c_n_max - self.c_n_0_dim) / T
)
Expand All @@ -295,7 +295,7 @@ def D_p_dimensional(self, sto, T):
"""Dimensional diffusivity in positive particle. Note this is defined as a
function of stochiometry"""
inputs = {"Positive particle stoichiometry": sto, "Temperature [K]": T}
if self.options["particle cracking"] is not None:
if self.options["particle cracking"] != "none":
mech_effects = (
1 + self.theta_p_dim * (sto * self.c_p_max - self.c_p_0_dim) / T
)
Expand Down Expand Up @@ -919,7 +919,7 @@ def options(self, extra_options):
extra_options = extra_options or {}

# Default options
options = {"particle shape": "spherical", "particle cracking": None}
options = {"particle shape": "spherical", "particle cracking": "none"}

# All model options get passed to the parameter class, so we just need
# to update the options in the default options and ignore the rest
Expand All @@ -936,7 +936,7 @@ def options(self, extra_options):
)

if options["particle cracking"] not in [
None,
"none",
"no cracking",
"cathode",
"anode",
Expand Down

0 comments on commit 35d5988

Please sign in to comment.