Fixing no gradient player background when using "pure black" theme. #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @useBlackBackground variable now factors in the player background style @playerBackground state - Player background now changes on the following (@mediaMetadata, @playerBackground, @DarkTheme, @useBlackBackground) to factor all possible theme configurations - "gradientColors.size >= 2" usage replaced with @hasGradientColours - Refactors @onBackgroundColor calculation into separate code segments for readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #462
useBlackBackgroundnow considersplayerBackgroundstatemediaMetadata,playerBackground,darkTheme,useBlackBackground) to cover all possible theme configurations and state changes.hasGradientColoursto representgradientColors.size >= 2for readability.onBackgroundColorcalculation into separate code segments for better readabilityAdditional packages:
None
Screenshots:
Light Mode
Light Mode + Dynamic
Light Mode + Gradient
Light Mode + Dynamic + Gradient
Dark Mode
Dark Mode + Dynamic
Dark Mode + Gradient (with/without Pure Black)
Dark Mode + Dynamic + Gradient (with/without Pure Black)
Dark Mode + Pure Black
Dark Mode + Dynamic + Pure Black