Fix "Unknown Error" on Playback Request Due to InnerTube API Changes #468
+396
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced Piped Streams with direct YouTube streams for `YouTube.player()`, as [pipedapi.kevin.rocks](https://pipedapi.kevin.rocks) is down. **Note**: Direct streams seem to cause issues once in a while, such as playback interrupts or timeouts. - Added support for signature timestamps in `YouTube.player()`, fetched from InnerTube using the media ID, for clients requiring signature timestamps. - Playback and stream fetching handled in `innertune/utils/YTPlayerUtils.kt`. - Extraction/Deobfuscation of `PlayerResponse` data is handled in `innertube/utils/NewPipeUtils.kt`. - Updated 'YoutubeClient' clients to reflect changes. - Fixed Kugou test causing build errors ### Additional Changes: - Added [libs.newpipeExtractor](https://github.com/TeamNewPipe/NewPipeExtractor) to `libs.versions.toml` and `innertube/build.gradle`.
…layer requests (doesn't appear to be used anymore)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should: fix #433, fix #438, fix #445, fix #463, fix #467
Summary:
Due to recent InnerTube changes, playback data and valid streams cannot be returned to the client, resulting in 403 responses or invalid playability status in the
PlayerResponse. A similar solution is used in OuterTune and Metrolist to handle these issues. Credits: @gechoto.Note: Direct streams seem to cause issues once in a while, such as playback interrupts or timeouts. This might be due to the current version of NewPipeExtractor (0.24.4) failing to deobfuscate Throttling Params. Commit 1ca8275 resolves this, so maybe that could be used in the meantime until the next version release?