Add run-time flag for in-app browser privacy

https://bugs.webkit.org/show_bug.cgi?id=205288 <rdar://problem/57569206> Reviewed by John Wilander. Source/WebCore: * page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setInAppBrowserPrivacyEnabled): (WebCore::RuntimeEnabledFeatures::isInAppBrowserPrivacyEnabled const): * page/Settings.yaml: Source/WebKit: * Shared/WebPreferences.yaml: Source/WebKitLegacy/mac: * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isInAppBrowserPrivacyEnabled]): (-[WebPreferences setInAppBrowserPrivacyEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@253655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Man1029 · Dec 17, 2019 · f93530c · f93530c
1 parent adc7611
commit f93530c
Show file tree

Hide file tree

Showing 10 changed files with 73 additions and 0 deletions.
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2019-12-17  Kate Cheney  <[email protected]>
+
+        Add run-time flag for in-app browser privacy
+        https://bugs.webkit.org/show_bug.cgi?id=205288
+        <rdar://problem/57569206>
+
+        Reviewed by John Wilander.
+
+        * page/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::setInAppBrowserPrivacyEnabled):
+        (WebCore::RuntimeEnabledFeatures::isInAppBrowserPrivacyEnabled const):
+        * page/Settings.yaml:
+
 2019-12-17  Ryosuke Niwa  <[email protected]>
 
         executeIfJavaScriptURL should check requester's security origin

diff --git a/Source/WebCore/page/RuntimeEnabledFeatures.h b/Source/WebCore/page/RuntimeEnabledFeatures.h
@@ -389,6 +389,9 @@ class RuntimeEnabledFeatures {
     bool secureContextChecksEnabled() const { return m_secureContextChecksEnabled; }
     void setSecureContextChecksEnabled(bool isEnabled) { m_secureContextChecksEnabled = isEnabled; }
 
+    void setIsInAppBrowserPrivacyEnabled(bool isEnabled) { m_isInAppBrowserPrivacyEnabled = isEnabled; }
+    bool isInAppBrowserPrivacyEnabled() const { return m_isInAppBrowserPrivacyEnabled; }
+
 private:
     // Never instantiate.
     RuntimeEnabledFeatures();
@@ -584,6 +587,8 @@ class RuntimeEnabledFeatures {
     bool m_secureContextChecksEnabled { true };
     bool m_isCSSShadowPartsEnabled { true };
 
+    bool m_isInAppBrowserPrivacyEnabled { false };
+
     friend class WTF::NeverDestroyed<RuntimeEnabledFeatures>;
 };
 

diff --git a/Source/WebCore/page/Settings.yaml b/Source/WebCore/page/Settings.yaml
@@ -906,6 +906,9 @@ legacyGetUserMediaEnabled:
   initial: false
   conditional: MEDIA_STREAM
 
+isInAppBrowserPrivacyEnabled:
+  initial: false
+
 # Deprecated
 
 iceCandidateFilteringEnabled:

diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
@@ -1,3 +1,13 @@
+2019-12-17  Kate Cheney  <[email protected]>
+
+        Add run-time flag for in-app browser privacy
+        https://bugs.webkit.org/show_bug.cgi?id=205288
+        <rdar://problem/57569206>
+
+        Reviewed by John Wilander.
+
+        * Shared/WebPreferences.yaml:
+
 2019-12-17  Ben Nham  <[email protected]>
 
         Navigation from empty page doesn't use cached web process

diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
@@ -1877,6 +1877,14 @@ UseGPUProcessForMedia:
     category: internal
     webcoreName: useGPUProcessForMedia
 
+IsInAppBrowserPrivacyEnabled:
+    type: bool
+    defaultValue: true
+    humanReadableName: "In-App Browser Privacy"
+    humanReadableDescription: "Enable In-App Browser Privacy"
+    webcoreBinding: RuntimeEnabledFeatures
+    category: internal
+
 # Deprecated
 
 ICECandidateFilteringEnabled:

diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
@@ -1,3 +1,20 @@
+2019-12-17  Kate Cheney  <[email protected]>
+
+        Add run-time flag for in-app browser privacy
+        https://bugs.webkit.org/show_bug.cgi?id=205288
+        <rdar://problem/57569206>
+
+        Reviewed by John Wilander.
+
+        * WebView/WebPreferenceKeysPrivate.h:
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]):
+        (-[WebPreferences isInAppBrowserPrivacyEnabled]):
+        (-[WebPreferences setInAppBrowserPrivacyEnabled:]):
+        * WebView/WebPreferencesPrivate.h:
+        * WebView/WebView.mm:
+        (-[WebView _preferencesChanged:]):
+
 2019-12-16  Simon Fraser  <[email protected]>
 
         Change 'delegatesPageScaling' from a Setting to a flag on ScrollView

diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h b/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
@@ -280,4 +280,5 @@
 #define WebKitRequestIdleCallbackEnabledPreferenceKey @"WebKitRequestIdleCallbackEnabled"
 #define WebKitAsyncClipboardAPIEnabledPreferenceKey @"WebKitAsyncClipboardAPIEnabled"
 #define WebKitLinkPreloadResponsiveImagesEnabledPreferenceKey @"WebKitLinkPreloadResponsiveImagesEnabled"
+#define WebKitInAppBrowserPrivacyEnabledPreferenceKey @"WebKitInAppBrowserPrivacyEnabled"
 
diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
@@ -706,6 +706,7 @@ + (void)initialize
         @NO, WebKitAsyncClipboardAPIEnabledPreferenceKey,
         @NO, WebKitLinkPreloadResponsiveImagesEnabledPreferenceKey,
         @YES, WebKitCSSShadowPartsEnabledPreferenceKey,
+        @NO, WebKitInAppBrowserPrivacyEnabledPreferenceKey,
         nil];
 
 #if !PLATFORM(IOS_FAMILY)
@@ -3601,6 +3602,17 @@ - (void)setRemotePlaybackEnabled:(BOOL)remotePlaybackEnabled
 {
     [self _setBoolValue:remotePlaybackEnabled forKey:WebKitRemotePlaybackEnabledPreferenceKey];
 }
+
+- (BOOL)isInAppBrowserPrivacyEnabled
+{
+    return [self _boolValueForKey:WebKitInAppBrowserPrivacyEnabledPreferenceKey];
+}
+
+- (void)setInAppBrowserPrivacyEnabled:(BOOL)flag
+{
+    [self _setBoolValue:flag forKey:WebKitInAppBrowserPrivacyEnabledPreferenceKey];
+}
+
 @end
 
 @implementation WebPreferences (WebInternal)

diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h b/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
@@ -630,6 +630,9 @@ extern NSString *WebPreferencesCacheModelChangedInternalNotification WEBKIT_DEPR
 - (void)setCSSShadowPartsEnabled:(BOOL)flag;
 - (BOOL)cssShadowPartsEnabled;
 
+- (BOOL)isInAppBrowserPrivacyEnabled;
+- (void)setInAppBrowserPrivacyEnabled:(BOOL)flag;
+
 @property (nonatomic) BOOL visualViewportAPIEnabled;
 @property (nonatomic) BOOL CSSOMViewScrollingAPIEnabled;
 @property (nonatomic) BOOL largeImageAsyncDecodingEnabled;

diff --git a/Source/WebKitLegacy/mac/WebView/WebView.mm b/Source/WebKitLegacy/mac/WebView/WebView.mm
@@ -3192,6 +3192,7 @@ - (void)_preferencesChanged:(WebPreferences *)preferences
     RuntimeEnabledFeatures::sharedFeatures().setDialogElementEnabled([preferences dialogElementEnabled]);
     RuntimeEnabledFeatures::sharedFeatures().setKeygenElementEnabled([preferences keygenElementEnabled]);
     RuntimeEnabledFeatures::sharedFeatures().setCSSShadowPartsEnabled([preferences cssShadowPartsEnabled]);
+    RuntimeEnabledFeatures::sharedFeatures().setIsInAppBrowserPrivacyEnabled([preferences isInAppBrowserPrivacyEnabled]);
 
 #if ENABLE(LEGACY_ENCRYPTED_MEDIA)
     RuntimeEnabledFeatures::sharedFeatures().setLegacyEncryptedMediaAPIEnabled(preferences.legacyEncryptedMediaAPIEnabled);