Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle asset_host #30

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

handle asset_host #30

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4107951
handle an asset_host on the mailer (as a string)
afeld Dec 29, 2014
2f6f230
handle asset_hosts that are Procs
afeld Dec 29, 2014
45696cc
update information around the asset_host
afeld Dec 29, 2014
dbdb132
include the asset_host logic in the Mailer
afeld Dec 29, 2014
d206c2c
extract asset_host specs
afeld Dec 29, 2014
b46da40
re-simplify mailer_spec
afeld Dec 29, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update information around the asset_host
  • Loading branch information
@afeld
afeld committed Dec 29, 2014
commit 45696ccaa24f2abc9d86a18ea1a2380dbde232b2
13 changes: 4 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,18 +256,13 @@ end

## Known issues ##

Roadie will not be able to find your stylesheets if you have an `asset_host` configured and will ignore those lines when inlining.

A workaround for this is to not use `asset_host` in your mailers:
If you need to set an `asset_host` in your mailer, it must be done before `Roadie::Rails::Automatic` is `include`d. For example:

```ruby
config.action_controller.asset_host = # ...
config.action_mailer.asset_host = nil

# or

class MyMailer < ActionMailer::Base
self.asset_host = nil
self.asset_host = 'http://mail-cdn.mysite.com'

include Roadie::Rails::Automatic
end
```

Expand Down