Decoupled the Console Presentation from the Core Logic into a Service #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to separate out the core logic for:
1. Better testability
- Adding functional tests will be easier now that we have removed the Console App based calls from the service.
- Performance testing will also be much easier as it'll be easier to concoct up benchmarking + scenario based perf testing.
2. Better extensibility such as changing the presentation
- Envisioning different presentations can be built on top of the service such as that of a CSV file output or XAML based presentation.
- By encapsulating the GCEnd logic into a simple Observable, we can start building more automated analysis tools (got a # of ideas here and will be happy to discuss via a PR).
We moved the core logic of the
GCEnd
event into it's own abstraction - the GCRealTimeMonService that's accessed via theIGCRealTimeMonService
interface. The contract from the client of the service is to subscribe to the GCEndObservable to obtain the GCEnd events in realtime and call dispose on theIGCRealTimeMonResult
once the program is to exit.Usage:
When the process needs to exit: