Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupled the Console Presentation from the Core Logic into a Service #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MokoSan
Copy link
Contributor

@MokoSan MokoSan commented Dec 8, 2021

In an effort to separate out the core logic for:

1. Better testability
- Adding functional tests will be easier now that we have removed the Console App based calls from the service.
- Performance testing will also be much easier as it'll be easier to concoct up benchmarking + scenario based perf testing.
2. Better extensibility such as changing the presentation
- Envisioning different presentations can be built on top of the service such as that of a CSV file output or XAML based presentation.
- By encapsulating the GCEnd logic into a simple Observable, we can start building more automated analysis tools (got a # of ideas here and will be happy to discuss via a PR).

We moved the core logic of the GCEnd event into it's own abstraction - the GCRealTimeMonService that's accessed via the IGCRealTimeMonService interface. The contract from the client of the service is to subscribe to the GCEndObservable to obtain the GCEnd events in realtime and call dispose on the IGCRealTimeMonResult once the program is to exit.

Usage:

      IGCRealTimeMonResult result = GCRealTimeMonService.Instance.Value.Initialize(pid: pid, configuration: configuration);
      
      IDisposable subscriptionHandle = result.GCEndObservable.Subscribe(gc =>
      {
          lock (writerLock)
          {
              Console.WriteLine(PrintUtilities.GetRowDetails(gc, configuration));
          }
      });

      result.Source.Process();

When the process needs to exit:

result.Dispose();

@Maoni0
Copy link
Owner

Maoni0 commented Jan 22, 2022

LGTM - if you could resolve conflicts we can merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants