Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from w3c:master #2

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 28, 2020

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

- Integrate code from the DAISY Consortium to parse and compare SMIL
  clock values
- Update check: move the clipBegin/clipEnd equality test into Java code
  so it works even with different SMIL clock syntaxes
- New check: clipBegin is not temporally after clipEnd
- Add and update associated tests
Add the following new errors:
- Error MED-010 when an item is missing a media-overlay attribute
- Error MED-011 when the media-overlay attribute references the wrong
  overlay
- Error MED-012 when the media-overlay attribute references an overlay
  that does not reference the underlying content document
- Error MED-013 when a content doc is referenced from multiple overlays

Also Add tests for the new errors.

Implementation note:
- pull the unique references from the text elements while parsing
  the overlay documents
- then run checks on the affected content documents in the post-processing
  function.
@pull pull bot added the ⤵️ pull label Dec 28, 2020
mattgarrish and others added 27 commits December 28, 2020 12:19
… elements

- Check the value of the `epub:textref` attribute when found on `body`
  or `seq` elements
- New error MED-014 is reported when a fragment has been specified in
  `epub:textref` and `src` attributes
- RSC-012 is reported when the resource referenced in `epub.textref`
  could not be found
- Report OPF-014 when a remote audio file is used in Media Overlays
  and the `remote-resources` prroperty is not declared in the Package
  Document.

Implementation notes:
- flag references to remote resources when parsing `audio` elements
- check that the `remote-resources` property is correctly set in the
  package item declaration when at the end of the SMIL parsing
Report new error MED-015 when the order of text elements in a Media
Overlay does not match the DOM order of the referenced elements in the
corresponding content document(s).

Applies PR #1180
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1.
- [Release notes](https://github.com/junit-team/junit4/releases)
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md)
- [Commits](junit-team/junit4@r4.12...r4.13.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* use license-maven-plugin v1.20 (v2.0.0 requires Maven v3.5.4, which apparently isn't available on Travis CI)
* fix file name case for `THIRD-PARTY.ftl`
…ntent documents

Add a schema rule to check the media type of items declaring
a `media-overlay` attribute

See #1176
The `glossary` manifest item property is defined in the EPUB dictionaries
and Glossaries 1.0 specification:
  http://idpf.org/epub/dict/epub-dict.html#sec-2.5.3

This fix allows the property to be defined on XHTML manifest items when
the content contains an element with a `glossary` `epub:type` attribute.

Fixes #1170
The cardinality of refining properties defined with the `meta` element
is defined in Appendix C "Meta Properties Vocabulary":
  https://www.w3.org/publishing/epub32/epub-packages.html#app-meta-property-vocab

Summary:
- add schematron rules to check that properties defined as
"zero or one" are not defined more than once
- add test for all properties
- rename some existing tests for consistency

Fixes #1121
The previous implementation of the `removeWorkingDirectory` utility
method was quite brutal and replaced all occurences of the "user.dir"
system property in paths, even when found in the middle of the path.

The new implementation only replaces the user directory when it occurs
at the beginning of the path, and does nothing when the user directory
is set to the root directory ("/").

Tests included.

Fixes #1181
Fix the regex used to report "file:" hyperlinks as `HTM-053` (informative)
to only consider HTML elements and not plain text.

This regex-based parsing is still brittle, but we'll refactor this whole
package later. For now this simple fix will do.

Fixes #1182
CSS defines a special processing for the resolution of fragment-only URLs.
These are resolved based on the HTML document, not relative to the
stylesheet.

For example, an SVG filter inlined in the HTML can be refered in CSS as:

```
* {
  filter: url(#filter);
}
```

Such fragment-only URLs were previously reported as errors in EPUBCheck,
since the related fragment could not be found in the CSS document!

This change fixes the issue by ignoring fragment-only URLs in CSS. In
other words, these URLs will not be registered to the XRefChecker.

Fixes #1198
An empty `xml:lang` attribute can explicitly indicate that the content
does not inherit the context language.

Fixes #777
…dex Publication

This fix removes the index-specific schemas when checking the Navigation
Document.

It is probably too simple, a better implementation would only do so if
the Nav Doc is not in the spine or is not the only Content Document in
the spine, but there is no easy way to check that latter condition in
the NavChecker.
The fix is a reasonable compromise, as a false-negative (the Nav Doc
**must** have index content when it is the unique Content Document) should
be pretty rare, and is always better than a false-positive.

Fixes #1122
See issue #446

There is a false-positive, but it's acceptable until we properly
adopt the Nu HTML Checker
Configure Travis to cache Maven’s `.m2` directory.
Some French properties files were not identified by the `file` command as 'ISO-8859' but as 'data'.
The grep expression is fixed to recognize them and make them go through the escape processing, like
other ISO-8859 content.
rdeltour added 7 commits June 29, 2021 15:39
…1258)

In EPUB 3.2, the 'role' property was only allowed to refine 'contributor'
or 'creator' properties, and only once per property. A new check was
introduced in EPUBCheck v4.2.5, and some users reported that it cause
issues with existing EPUB catalogs.

EPUB 3.3 will relax this by allowing authors to attach several roles to
creators, contributors, and publishers.

This commit proactively implements the relaxed EPUB 3.3 rules.

Fixes #1230
EPUBCheck v4.2.5 introduced a new check (MED-015) to report a mismatch
between Media Overlays and Content Document order.
But this rule will be relaxed in EPUB 3.3.

This commit preemptively demotes MED-015 to a USAGE.

See #1225. We'll decide if we want to totally remove the feature when we
fully implementat EPUB 3.3.
@rdeltour rdeltour deleted the branch MarcelRaschke:master July 2, 2021 12:21
@rdeltour rdeltour deleted the master branch July 2, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants