Skip to content

Commit

Permalink
Run Crowdin workflow only on private repo and update CODEOWNERS (#16010)
Browse files Browse the repository at this point in the history
* only run Crowdin workflow on private repo

Co-Authored-By: Chiedo John <[email protected]>

* organize codeowners for localization-related files

Co-Authored-By: Chiedo John <[email protected]>

* do not upload translations

Co-Authored-By: Chiedo John <[email protected]>

Co-authored-by: Chiedo John <[email protected]>
  • Loading branch information
zeke and chiedo authored Oct 13, 2020
1 parent 53482ec commit 5439891
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
9 changes: 7 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,21 @@
# https://help.github.com/articles/about-codeowners
# https://git-scm.com/docs/gitignore

/translations/ @github/docs-localization @github-actions
# Engineering
*.js @github/docs-engineering
/.github/ @github/docs-engineering
/script/ @github/docs-engineering
app.json @github/docs-engineering
crowdin.yml @github/docs-engineering
Dockerfile @github/docs-engineering
package-lock.json @github/docs-engineering
package.json @github/docs-engineering

# Localization
/.github/workflows/crowdin.yml @github/docs-localization
/crowdin*.yml @github/docs-engineering @github/docs-localization
/translations/ @github/docs-engineering @github/docs-localization @github-actions

# Site Policy
/content/github/site-policy/ @github/site-policy-admins

# Make sure that Octokit maintainers get notified about changes
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/crowdin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ on:
jobs:
sync_with_crowdin:
name: Sync with Crowdin
if: github.repository == 'github/docs-internal'
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -19,7 +20,7 @@ jobs:
- name: Sync
uses: crowdin/[email protected]
with:
upload_translations: true
upload_translations: false
download_translations: true
create_pull_request: true

Expand Down

0 comments on commit 5439891

Please sign in to comment.