Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Egor frolov lab1 #7

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Egorch-max
Copy link

src/tbitfield.cpp Show resolved Hide resolved
src/tbitfield.cpp Show resolved Hide resolved
src/tbitfield.cpp Show resolved Hide resolved
src/tbitfield.cpp Show resolved Hide resolved
src/tbitfield.cpp Outdated Show resolved Hide resolved
src/tbitfield.cpp Outdated Show resolved Hide resolved
src/tset.cpp Outdated Show resolved Hide resolved
src/tset.cpp Outdated Show resolved Hide resolved
src/tset.cpp Outdated Show resolved Hide resolved
src/tset.cpp Outdated Show resolved Hide resolved
@Egorch-max
Copy link
Author

Всё исправлено @Marina-Labinskaya

Copy link
Owner

@Marina-Labinskaya Marina-Labinskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лабу принимаю

@Egorch-max
Copy link
Author

@Marina-Labinskaya Fixtures ready

Copy link
Owner

@Marina-Labinskaya Marina-Labinskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вы определили только классы, нужно их применить в тестах

@Marina-Labinskaya
Copy link
Owner

Те же замечания, что и здесь: Marina-Labinskaya/mp2-lab2-matrix#16 (comment)

@Egorch-max
Copy link
Author

@Marina-Labinskaya добавил парочку для test_tset and test_tbitfield, достаточно?

@Marina-Labinskaya
Copy link
Owner

Да, нормально, только SetUp2() не используйте, в нём динамически выделяется память и не освобождается при выходе из теста - утечка памяти

@Egorch-max
Copy link
Author

@Marina-Labinskaya проверьте, пожалуйста

s = new TSet(5);
}

void TearDown() {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в TearDown() - delete s

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

исправил

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants