system-kmod-macros: Do not require the 'conntrack' tool.

We can use 'ovstest test-netlink-conntrack' instead. Now that it is not required anymore, we can remove the HAVE_CONNTRACK macro in the build system. Signed-off-by: Daniele Di Proietto <[email protected]> Acked-by: Joe Stringer <[email protected]>
MarkMielke · Dec 22, 2015 · ef0c5ff · ef0c5ff
1 parent a857bb6
commit ef0c5ff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/tests/atlocal.in b/tests/atlocal.in
@@ -111,13 +111,6 @@ if test "$IS_WIN32" = "yes"; then
     HAVE_PYTHON="no"
 fi
 
-# Conntrack test requirements
-if test x`which conntrack 2>/dev/null` != x; then
-    HAVE_CONNTRACK="yes"
-else
-    HAVE_CONNTRACK="no"
-fi
-
 if test "$HAVE_PYTHON" = "yes" \
    && test "x`$PYTHON $abs_top_srcdir/tests/test-l7.py --help | grep 'ftp'`" != x; then
     HAVE_PYFTPDLIB="yes"

diff --git a/tests/system-kmod-macros.at b/tests/system-kmod-macros.at
@@ -50,12 +50,11 @@ m4_define([OVS_TRAFFIC_VSWITCHD_STOP],
 # kernel conntrack tables when the test is finished.
 #
 m4_define([CHECK_CONNTRACK],
-    [AT_SKIP_IF([test $HAVE_CONNTRACK = no])
-     AT_SKIP_IF([test $HAVE_PYTHON = no])
+    [AT_SKIP_IF([test $HAVE_PYTHON = no])
      m4_foreach([mod], [[nf_conntrack_ipv4], [nf_conntrack_ipv6], [nf_nat_ftp]],
                 [modprobe mod || echo "Module mod not loaded."
                  on_exit 'modprobe -r mod'
                 ])
-     on_exit 'conntrack -F'
+     on_exit 'ovstest test-netlink-conntrack flush'
     ]
 )