Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added color themes and functionality to change them as well #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ujjwalshrma
Copy link

@ujjwalshrma ujjwalshrma commented Mar 19, 2023

This change adds the functionality to select a different colorscheme from the dropdown.

I added individual CSS files for each theme to not clutter the theme.css or any other CSS file.

@Markonis
Copy link
Owner

Hey I love this idea! 👏 Here are a few comments:

  • I would suggest installing the "EditorConfig for VS Code" extension so that we get consistent formatting. It's kind of like prettier, but much less complex and not as strict.
  • How do you feel about implementing the theme selection in the same way you can select the repository for typing? Not a requirement, just curious what you think? Maybe we can add a second question after choosing the repo to be like: "Oh would you like to change your theme?" And then you choose from one of the ones you implemented?

@ujjwalshrma
Copy link
Author

ujjwalshrma commented Mar 19, 2023

  • For the first point Marko, I was using Neovim, that's why the formatting was a bit off.

  • I appreciate your points but I thought that theme selection can be a bit easier, I tried to implement it like how it's done in "MonkeType". On the bottom of monkey type you can just simply change your theme by selecting it, also I think a dedicated question just for a theme would be too much as for VSCode and other editors we can set the themes by ourselves and the editor doesn't suggest us. (that's my analogy). I can also change the "Default" to "Select Theme" in the dropdown so it'll be more obvious for users to identify the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants