Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore invalid keys such as CTRL, Shift, alt, etc #3

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Ignore invalid keys such as CTRL, Shift, alt, etc #3

merged 2 commits into from
Mar 18, 2023

Conversation

lucaspalves
Copy link
Contributor

@lucaspalves lucaspalves commented Mar 17, 2023 •
edited
Loading

Ignore those keys to not break the timer.

#2

SJBrahma2008
SJBrahma2008 approved these changes Mar 17, 2023
View reviewed changes
Copy link

@SJBrahma2008 SJBrahma2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@mohsinsr
Copy link

LGTM!

Markonis
Markonis approved these changes Mar 18, 2023
View reviewed changes
Copy link
Owner

@Markonis Markonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you! 👍

@Markonis Markonis merged commit cf0bcc5 into Markonis:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SJBrahma2008 SJBrahma2008 SJBrahma2008 approved these changes

@Markonis Markonis Markonis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucaspalves @mohsinsr @Markonis @SJBrahma2008